Bug 41257 - ILL "List requests"/"Refresh" wording doesn't work
Summary: ILL "List requests"/"Refresh" wording doesn't work
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: ILL (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Pedro Amorim
QA Contact: Lisette Scheer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-11-17 14:42 UTC by Pedro Amorim
Modified: 2025-11-18 14:00 UTC (History)
4 users (show)

See Also:
GIT URL:
Initiative type: ---
Sponsorship status: ---
Comma delimited list of Sponsors:
Crowdfunding goal: 0
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
25.11.00
Circulation function:


Attachments
Bug 41257: Fix wording condition check (1.40 KB, patch)
2025-11-17 14:44 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 41257: Remove 'btn-sm' CSS class (1.66 KB, patch)
2025-11-17 14:44 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 41257: Remove 'btn-sm' CSS class (1.72 KB, patch)
2025-11-17 20:49 UTC, Lisette Scheer
Details | Diff | Splinter Review
Bug 41257: Fix wording condition check (1.46 KB, patch)
2025-11-17 20:50 UTC, Lisette Scheer
Details | Diff | Splinter Review
Bug 41257: Fix wording condition check (1.46 KB, patch)
2025-11-17 22:18 UTC, Lisette Scheer
Details | Diff | Splinter Review
Bug 41257: Remove 'btn-sm' CSS class (1.72 KB, patch)
2025-11-17 22:19 UTC, Lisette Scheer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Pedro Amorim 2025-11-17 14:42:11 UTC
Likely caused by CSRF rewording of query_type => op in ill-requests.tt:
https://github.com/Koha-Community/Koha/commit/a9adee5

To reproduce:
1) Enable ILLModule
2) Visit ILL requests:
<staff_url>/cgi-bin/koha/ill/ill-requests.pl
3) Where 'List requests' show, it should show 'Refresh'
Comment 1 Pedro Amorim 2025-11-17 14:44:44 UTC
Created attachment 189631 [details] [review]
Bug 41257: Fix wording condition check

To reproduce:
1) Enable ILLModule
2) Visit ILL requests:
<staff_url>/cgi-bin/koha/ill/ill-requests.pl
3) Where 'List requests' show, it should show 'Refresh'.
4) Apply patches, refresh, notice it now shows 'Refresh'.
Comment 2 Pedro Amorim 2025-11-17 14:44:46 UTC
Created attachment 189632 [details] [review]
Bug 41257: Remove 'btn-sm' CSS class

It may have made sense in the past but I don't think it does anymore. It adds an odd bottom spacing to the button
Comment 3 Lisette Scheer 2025-11-17 20:49:37 UTC
Created attachment 189643 [details] [review]
Bug 41257: Remove 'btn-sm' CSS class

It may have made sense in the past but I don't think it does anymore. It adds an odd bottom spacing to the button

Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com>
Comment 4 Lisette Scheer 2025-11-17 20:50:17 UTC
Created attachment 189644 [details] [review]
Bug 41257: Fix wording condition check

To reproduce:
1) Enable ILLModule
2) Visit ILL requests:
<staff_url>/cgi-bin/koha/ill/ill-requests.pl
3) Where 'List requests' show, it should show 'Refresh'.
4) Apply patches, refresh, notice it now shows 'Refresh'.

Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com>
Comment 5 Lisette Scheer 2025-11-17 20:51:57 UTC
Small enough that I'm going to pass qa.
Comment 6 Lisette Scheer 2025-11-17 22:18:50 UTC
Created attachment 189646 [details] [review]
Bug 41257: Fix wording condition check

To reproduce:
1) Enable ILLModule
2) Visit ILL requests:
<staff_url>/cgi-bin/koha/ill/ill-requests.pl
3) Where 'List requests' show, it should show 'Refresh'.
4) Apply patches, refresh, notice it now shows 'Refresh'.

Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com>
Comment 7 Lisette Scheer 2025-11-17 22:19:13 UTC
Created attachment 189647 [details] [review]
Bug 41257: Remove 'btn-sm' CSS class

It may have made sense in the past but I don't think it does anymore. It adds an odd bottom spacing to the button

Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com>
Comment 8 Lisette Scheer 2025-11-17 22:19:35 UTC
Re uploaded the patches in the correct order.
Comment 9 Lucas Gass (lukeg) 2025-11-18 14:00:46 UTC
Nice work everyone!

Pushed to main for 25.11