Bug 41347

Summary: Terminology: Item had a reserve waiting
Product: Koha Reporter: Katrin Fischer <katrin.fischer>
Component: TemplatesAssignee: 22264cc
Status: Pushed to main --- QA Contact: Katrin Fischer <katrin.fischer>
Severity: trivial    
Priority: P5 - low CC: aleisha, david
Version: MainKeywords: Academy
Hardware: All   
OS: All   
GIT URL: Initiative type: ---
Sponsorship status: Sponsored Comma delimited list of Sponsors: Catalyst
Crowdfunding goal: 0 Patch complexity: String patch
Documentation contact: Documentation submission:
Text to go in the release notes:
This fixes the terminology for two log viewer messages: - "Item had a reserve waiting" to "Hold waiting on item" - "Item was reserved" to "Hold placed on item"
Version(s) released in:
26.05.00
Circulation function:
Attachments: Bug 41347: Terminology: Item had a reserve waiting
Bug 41347: Terminology: Item had a reserve waiting
Bug 41347: Terminology: Item had a reserve waiting

Description Katrin Fischer 2025-12-02 10:47:00 UTC
Found while translating:

Item had a reserve waiting
koha-tmpl/intranet-tmpl/prog/js/transport_status.js:2

reserve should be changed to hold or maybe booking.
Comment 1 Katrin Fischer 2025-12-02 10:48:20 UTC
Same here:

Item was reserved
koha-tmpl/intranet-tmpl/prog/en/includes/action-logs.inc:225

Item was placed on hold 
Item was booked 

?
Comment 2 Aleisha Amohia 2026-01-20 21:28:46 UTC
I don't see a reserve string in koha-tmpl/intranet-tmpl/prog/js/transport_status.js anymore.

However there are two in koha-tmpl/intranet-tmpl/prog/en/includes/action-logs.inc

'Item had a reserve waiting' should be changed to 'Hold waiting on item'

'Item was reserved' should be changed to 'Hold placed on item'
Comment 3 22264cc 2026-01-21 02:02:57 UTC
Created attachment 191734 [details] [review]
Bug 41347: Terminology: Item had a reserve waiting

"Item had a reserve waiting" changed to "Hold waiting on item"
"Item was reserved" changed to "hold placed on item"
Comment 4 David Nind 2026-01-21 19:09:09 UTC
Created attachment 191814 [details] [review]
Bug 41347: Terminology: Item had a reserve waiting

"Item had a reserve waiting" changed to "Hold waiting on item"
"Item was reserved" changed to "hold placed on item"

Signed-off-by: David Nind <david@davidnind.com>
Comment 5 David Nind 2026-01-21 19:13:48 UTC
Hi.

Thanks for the patch!

Entirely option, but if you would like your real name associated with the patch then let me know, and I'll update the patch author information.

This shows up in the Koha timeline page under about Koha, with new developer names shown (once a patch is pushed and included in a release).

It might also look good on your CV!

David
Comment 6 Katrin Fischer 2026-01-21 21:05:40 UTC
I notice that the patch changes the strings from past to present tense:

Item had a reserve waiting -->
Hold waiting on item

As these entries are for the action logs, a kind of protocol of actions, I am not sure which is better. Leasing final decision to native speakers :)
Comment 7 Katrin Fischer 2026-01-21 21:06:27 UTC
Created attachment 191833 [details] [review]
Bug 41347: Terminology: Item had a reserve waiting

"Item had a reserve waiting" changed to "Hold waiting on item"
"Item was reserved" changed to "hold placed on item"

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 8 David Nind 2026-01-22 18:52:07 UTC
(In reply to Katrin Fischer from comment #6)
> I notice that the patch changes the strings from past to present tense:
> 
> Item had a reserve waiting -->
> Hold waiting on item
> 
> As these entries are for the action logs, a kind of protocol of actions, I
> am not sure which is better. Leasing final decision to native speakers :)

If the normal approach for log messages is the past tense, then we should change it to keep it consistent.
Comment 9 Lucas Gass (lukeg) 2026-01-23 14:30:16 UTC
Nice work everyone!

Pushed to main for 26.05