Found while translating: Item had a reserve waiting koha-tmpl/intranet-tmpl/prog/js/transport_status.js:2 reserve should be changed to hold or maybe booking.
Same here: Item was reserved koha-tmpl/intranet-tmpl/prog/en/includes/action-logs.inc:225 Item was placed on hold Item was booked ?
I don't see a reserve string in koha-tmpl/intranet-tmpl/prog/js/transport_status.js anymore. However there are two in koha-tmpl/intranet-tmpl/prog/en/includes/action-logs.inc 'Item had a reserve waiting' should be changed to 'Hold waiting on item' 'Item was reserved' should be changed to 'Hold placed on item'
Created attachment 191734 [details] [review] Bug 41347: Terminology: Item had a reserve waiting "Item had a reserve waiting" changed to "Hold waiting on item" "Item was reserved" changed to "hold placed on item"
Created attachment 191814 [details] [review] Bug 41347: Terminology: Item had a reserve waiting "Item had a reserve waiting" changed to "Hold waiting on item" "Item was reserved" changed to "hold placed on item" Signed-off-by: David Nind <david@davidnind.com>
Hi. Thanks for the patch! Entirely option, but if you would like your real name associated with the patch then let me know, and I'll update the patch author information. This shows up in the Koha timeline page under about Koha, with new developer names shown (once a patch is pushed and included in a release). It might also look good on your CV! David
I notice that the patch changes the strings from past to present tense: Item had a reserve waiting --> Hold waiting on item As these entries are for the action logs, a kind of protocol of actions, I am not sure which is better. Leasing final decision to native speakers :)
Created attachment 191833 [details] [review] Bug 41347: Terminology: Item had a reserve waiting "Item had a reserve waiting" changed to "Hold waiting on item" "Item was reserved" changed to "hold placed on item" Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
(In reply to Katrin Fischer from comment #6) > I notice that the patch changes the strings from past to present tense: > > Item had a reserve waiting --> > Hold waiting on item > > As these entries are for the action logs, a kind of protocol of actions, I > am not sure which is better. Leasing final decision to native speakers :) If the normal approach for log messages is the past tense, then we should change it to keep it consistent.
Nice work everyone! Pushed to main for 26.05