| Summary: | Terminology: Target item cannot be reserved from other branches | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
| Component: | Templates | Assignee: | Owen Leonard <oleonard> |
| Status: | Pushed to stable --- | QA Contact: | Laura Escamilla <Laura.escamilla> |
| Severity: | trivial | ||
| Priority: | P5 - low | CC: | david, Laura.escamilla |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | String patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: |
Updates the terminology for two circulation-related messages (reserves to holds, branches to libraries):
- "Target item cannot be reserved from other branches" to "Target item cannot be placed on hold from other libraries"
- "No reserves allowed" to "No holds allowed"
|
Version(s) released in: |
26.05.00,25.11.01
|
| Circulation function: | |||
| Attachments: |
Bug 41395: Terminology: Target item cannot be reserved from other branches
Bug 41395: Terminology: Target item cannot be reserved from other branches Bug 41395: Terminology: Target item cannot be reserved from other branches |
||
|
Description
Katrin Fischer
2025-12-06 16:40:05 UTC
... and reserved: be placed on hold Same here: Target item cannot be placed on reserve for this branch koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt:223 (In reply to Katrin Fischer from comment #0) > Target item cannot be reserved from other branches > koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt:209 How does one trigger this error message? I am not sure :( It sounds a bit like it relates to certain circulation rule settings? Created attachment 190617 [details] [review] Bug 41395: Terminology: Target item cannot be reserved from other branches This patch corrects some terminology in the holds template, replacing "reserve" with "hold" and "branch" with "library." The patch also removes a duplicate CASE for cannotReserveFromOtherBranches. I'm not sure how to test, and I wonder whether this error intercepted earlier in the code somewhere. The change is simple, so I hope a check of the patch will be enough. Created attachment 190644 [details] [review] Bug 41395: Terminology: Target item cannot be reserved from other branches This patch corrects some terminology in the holds template, replacing "reserve" with "hold" and "branch" with "library." The patch also removes a duplicate CASE for cannotReserveFromOtherBranches. I'm not sure how to test, and I wonder whether this error intercepted earlier in the code somewhere. The change is simple, so I hope a check of the patch will be enough. Signed-off-by: David Nind <david@davidnind.com> Created attachment 190678 [details] [review] Bug 41395: Terminology: Target item cannot be reserved from other branches Testing Steps 1. Set the system preference CanReserveFromOtherBranches to “Don’t allow.” 2. Enable the system preference IndependentBranches. 3. Place a hold on an item from your local branch. 4. View the existing hold and select it. 5. Click “Move selected”, then choose “Record level holds to a different record.” * For testing, the original hold was placed on biblionumber 10 (Centerville item). * The hold was then moved to biblionumber 41 (Fairview item), which should not allow holds from another branch. 6. Observe the error message: “Hold ID: 4 Target item cannot be reserved from other branches.” 7. Apply the patch and refresh the page. 8. Observe the updated error message: “Hold ID: 4 Target item cannot be placed on hold from other libraries.” Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> Nice work everyone! Pushed to main for 26.05 Thanks all, pushed to 25.11.x |