| Summary: | Terminology: branch should be library in FilterSearchResultsByLoggedInBranch | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Caroline Cyr La Rose <caroline.cyr-la-rose> |
| Component: | Staff interface | Assignee: | Caroline Cyr La Rose <caroline.cyr-la-rose> |
| Status: | Pushed to stable --- | QA Contact: | David Nind <david> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | david, gmcharlt, katrin.fischer |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | String patch |
| Documentation contact: | Caroline Cyr La Rose | Documentation submission: | https://gitlab.com/koha-community/koha-manual/-/merge_requests/1145 |
| Text to go in the release notes: |
This fixes the terminology and improves the description for the FilterSearchResultsByLoggedInBranch system preference - branch should be library.
|
Version(s) released in: |
26.05.00,25.11.01
|
| Circulation function: | |||
| Bug Depends on: | 37883 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 41427: Rephrase FilterSearchResultsByLoggedInBranch description
Bug 41427: Rephrase FilterSearchResultsByLoggedInBranch description Bug 41427: Rephrase FilterSearchResultsByLoggedInBranch description Bug 41427: (QA follow-up) Add new line at end of file |
||
|
Description
Caroline Cyr La Rose
2025-12-10 19:33:02 UTC
Created attachment 190417 [details] [review] Bug 41427: Rephrase FilterSearchResultsByLoggedInBranch description This patch rephrases the description of the FilterSearchResultsByLoggedInBranch system preference to make it clear it filters items by the library where the user is currently logged in at. It also changes "branch" to "library" in the system preference description. To test: 1. Apply patch 2. Go to Administration > System preferences 3. Search for FilterSearchResultsByLoggedInBranch 4. Read the description, make sure it makes sense, and that the grammar and spelling are correct I also find misleading the part "the logged in user branch". I feel like it implies that it will filter the items by the branch of the logged in user. But the feature is to filter items by the branch **where** the user is logged in. Maybe it's just my french-speaking brain misunderstanding the sentence. If possible, I'd like a native english speaker to chime in? Created attachment 190418 [details] [review] Bug 41427: Rephrase FilterSearchResultsByLoggedInBranch description This patch rephrases the description of the FilterSearchResultsByLoggedInBranch system preference to make it clear it filters items by the library where the user is currently logged in at. It also changes "branch" to "library" in the system preference description. To test: 1. Apply patch 2. Go to Administration > System preferences 3. Search for FilterSearchResultsByLoggedInBranch 4. Read the description, make sure it makes sense, and that the grammar and spelling are correct Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 190445 [details] [review] Bug 41427: Rephrase FilterSearchResultsByLoggedInBranch description This patch rephrases the description of the FilterSearchResultsByLoggedInBranch system preference to make it clear it filters items by the library where the user is currently logged in at. It also changes "branch" to "library" in the system preference description. To test: 1. Apply patch 2. Go to Administration > System preferences 3. Search for FilterSearchResultsByLoggedInBranch 4. Read the description, make sure it makes sense, and that the grammar and spelling are correct Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: David Nind <david@davidnind.com> Created attachment 190446 [details] [review] Bug 41427: (QA follow-up) Add new line at end of file Signed-off-by: David Nind <david@davidnind.com> Added a follow-up to add a new line at the end of the file - running qa identified this. However, running prove xt/find-missing-new-lines-at-the-end-of-file.t (see bug 40541) didn't pick up that there was no new line. *** Bug 41394 has been marked as a duplicate of this bug. *** Nice work everyone! Pushed to main for 26.05 The system preference is in 25.11 and 25.05. If the patch could be backported, it would be great! Thanks all, pushed to 25.11.x |