Bug 41427

Summary: Terminology: branch should be library in FilterSearchResultsByLoggedInBranch
Product: Koha Reporter: Caroline Cyr La Rose <caroline.cyr-la-rose>
Component: Staff interfaceAssignee: Caroline Cyr La Rose <caroline.cyr-la-rose>
Status: Pushed to stable --- QA Contact: David Nind <david>
Severity: minor    
Priority: P5 - low CC: david, gmcharlt, katrin.fischer
Version: Main   
Hardware: All   
OS: All   
GIT URL: Initiative type: ---
Sponsorship status: --- Comma delimited list of Sponsors:
Crowdfunding goal: 0 Patch complexity: String patch
Documentation contact: Caroline Cyr La Rose Documentation submission: https://gitlab.com/koha-community/koha-manual/-/merge_requests/1145
Text to go in the release notes:
This fixes the terminology and improves the description for the FilterSearchResultsByLoggedInBranch system preference - branch should be library.
Version(s) released in:
26.05.00,25.11.01
Circulation function:
Bug Depends on: 37883    
Bug Blocks:    
Attachments: Bug 41427: Rephrase FilterSearchResultsByLoggedInBranch description
Bug 41427: Rephrase FilterSearchResultsByLoggedInBranch description
Bug 41427: Rephrase FilterSearchResultsByLoggedInBranch description
Bug 41427: (QA follow-up) Add new line at end of file

Description Caroline Cyr La Rose 2025-12-10 19:33:02 UTC
The term "library" is preferred to "branch" in the staff interface https://wiki.koha-community.org/wiki/Terminology#B

Bug 37883 introduced a new system preference with "branch".

FilterSearchResultsByLoggedInBranch : Don't/Do add a filter to the location column on staff interface search results to filter items by the logged in user branch.
Comment 1 Caroline Cyr La Rose 2025-12-10 19:44:51 UTC Comment hidden (obsolete)
Comment 2 Caroline Cyr La Rose 2025-12-10 19:47:19 UTC
I also find misleading the part "the logged in user branch". I feel like it implies that it will filter the items by the branch of the logged in user. But the feature is to filter items by the branch **where** the user is logged in.
Maybe it's just my french-speaking brain misunderstanding the sentence. If possible, I'd like a native english speaker to chime in?
Comment 3 Owen Leonard 2025-12-10 20:35:29 UTC Comment hidden (obsolete)
Comment 4 David Nind 2025-12-11 21:13:03 UTC
Created attachment 190445 [details] [review]
Bug 41427: Rephrase FilterSearchResultsByLoggedInBranch description

This patch rephrases the description of the
FilterSearchResultsByLoggedInBranch system preference to make it
clear it filters items by the library where the user is currently
logged in at. It also changes "branch" to "library" in the
system preference description.

To test:
1. Apply patch
2. Go to Administration > System preferences
3. Search for FilterSearchResultsByLoggedInBranch
4. Read the description, make sure it makes sense, and that the
   grammar and spelling are correct

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: David Nind <david@davidnind.com>
Comment 5 David Nind 2025-12-11 21:13:06 UTC
Created attachment 190446 [details] [review]
Bug 41427: (QA follow-up) Add new line at end of file

Signed-off-by: David Nind <david@davidnind.com>
Comment 6 David Nind 2025-12-11 21:16:04 UTC
Added a follow-up to add a new line at the end of the file - running qa identified this.

However, running prove xt/find-missing-new-lines-at-the-end-of-file.t (see bug 40541) didn't pick up that there was no new line.
Comment 7 Owen Leonard 2025-12-17 13:25:45 UTC
*** Bug 41394 has been marked as a duplicate of this bug. ***
Comment 8 Lucas Gass (lukeg) 2025-12-17 20:27:20 UTC
Nice work everyone!

Pushed to main for 26.05
Comment 9 Caroline Cyr La Rose 2025-12-18 15:42:46 UTC
The system preference is in 25.11 and 25.05. If the patch could be backported, it would be great!
Comment 10 Jacob O'Mara 2026-01-16 16:18:29 UTC
Thanks all, pushed to 25.11.x