| Summary: | "tab" variable in admin/aqbudgetperiods.pl,tt is not used and should be removed | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
| Component: | Architecture, internals, and plumbing | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | Pushed to main --- | QA Contact: | Marcel de Rooy <m.de.rooy> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | m.de.rooy |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
26.05.00
|
|
| Circulation function: | |||
| Bug Depends on: | 8117, 13464 | ||
| Bug Blocks: | 41564 | ||
| Attachments: |
Bug 41561: Remove 'tab' from admin/aqbudgetperiods
Bug 41561: Remove 'tab' from admin/aqbudgetperiods Bug 41561: Remove 'tab' from admin/aqbudgetperiods |
||
Created attachment 191061 [details] [review] Bug 41561: Remove 'tab' from admin/aqbudgetperiods commit 4b312b141ab2dddfac5da1034338a1634cb504e4 CommitDate: Wed Sep 19 16:17:16 2012 +0200 Bug 8117: Divide budget periods into two tabs It was used at the time +$url = "aqbudgetperiods.pl?tab=2"; But this has been removed by commit 870104ce117f8c4a303107fb24c8c3d2b7a886b0 Date: Mon Mar 21 09:32:39 2016 -0400 Bug 13464 - Standardize the pagination class Created attachment 191870 [details] [review] Bug 41561: Remove 'tab' from admin/aqbudgetperiods commit 4b312b141ab2dddfac5da1034338a1634cb504e4 CommitDate: Wed Sep 19 16:17:16 2012 +0200 Bug 8117: Divide budget periods into two tabs It was used at the time +$url = "aqbudgetperiods.pl?tab=2"; But this has been removed by commit 870104ce117f8c4a303107fb24c8c3d2b7a886b0 Date: Mon Mar 21 09:32:39 2016 -0400 Bug 13464 - Standardize the pagination class Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 191915 [details] [review] Bug 41561: Remove 'tab' from admin/aqbudgetperiods commit 4b312b141ab2dddfac5da1034338a1634cb504e4 CommitDate: Wed Sep 19 16:17:16 2012 +0200 Bug 8117: Divide budget periods into two tabs It was used at the time +$url = "aqbudgetperiods.pl?tab=2"; But this has been removed by commit 870104ce117f8c4a303107fb24c8c3d2b7a886b0 Date: Mon Mar 21 09:32:39 2016 -0400 Bug 13464 - Standardize the pagination class Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Nice work everyone! Pushed to main for 26.05 |
admin/aqbudgetperiods.pl my $tab = $input->param('tab') ? $input->param('tab') - 1 : 0; This is never used.