|
Description
Jonathan Druart
2026-01-09 13:58:01 UTC
Created attachment 191103 [details] [review] Bug 41566: Tidy kohaTable - catalogue/issuehistory Patch from commit ada6d06 Created attachment 191104 [details] [review] Bug 41566: Tidy kohaTable - catalogue/itemsearch.tt Patch from commit 7e49732 Created attachment 191105 [details] [review] Bug 41566: Tidy kohaTable - catalogue_detail.inc|catalogue/detail.tt This is a non-trivial one. * SpineLabelShowPrintOnBibDetails is removed from the controller and we fetch it from the Koha.Preference TT plugin (because it is how it should be) * A lot of JS variable instantiations are moved in a dedicated script tag: they all use TT plugins * We are using stores to permissions and sysprefs That's a lot of changes but nothing complicated, just a move from TT vars to JS vars To test this you will need to fully test the holdings tables. Created attachment 191106 [details] [review] Bug 41566: catalogue - auto tidy Patch from commit 5933c95 Created attachment 192726 [details] [review] Bug 41566: catalogue - auto tidy Patch from commit 0aeaf40 Created attachment 192787 [details] [review] Bug 41566: Tidy kohaTable - catalogue/issuehistory Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> Created attachment 192788 [details] [review] Bug 41566: Tidy kohaTable - catalogue/itemsearch.tt Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> Created attachment 192789 [details] [review] Bug 41566: Tidy kohaTable - catalogue_detail.inc|catalogue/detail.tt This is a non-trivial one. * SpineLabelShowPrintOnBibDetails is removed from the controller and we fetch it from the Koha.Preference TT plugin (because it is how it should be) * A lot of JS variable instantiations are moved in a dedicated script tag: they all use TT plugins * We are using stores to permissions and sysprefs That's a lot of changes but nothing complicated, just a move from TT vars to JS vars To test this you will need to fully test the holdings tables. Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> Created attachment 192790 [details] [review] Bug 41566: catalogue - auto tidy Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> Created attachment 192793 [details] [review] Bug 41566: (follow-up) Prevent runtime error by assigning int to ClaimReturnedLostValue Created attachment 192794 [details] [review] Bug 41566: (follow-up) Prevent runtime error by assigning fallback falsy value to ClaimReturnedLostValue |