Bug 35211 has some problems. 1. This is hard to read/maintain: const branchcodes = { [% FOREACH key IN branchcodes.keys %] "[% key | html %]": [ [% FOREACH code IN branchcodes.$key %] "[% code | html %]"[% UNLESS loop.last %], [% END %] [% END %] ][% UNLESS loop.last %], [% END %] [% END %] }; 2. If you select Show/Hide filters on the group holdings table the table disappears. 3. other_holdings_count is counted over and over inside the loop, it isn't necessary to do so. 4. The code seems to unnecessarily touch colvis settings
Created attachment 191470 [details] [review] Bug 41624: Improve how branchcodes are handled -This patch is an attempt to improve how we retrive branchcodes. Too much of this logic is unnesseary done in the template. -This also removed the unneeded "use Koha::Library::Group;"
Created attachment 191471 [details] [review] Bug 41624: Move other_holdings_count outside of loop so it is only calculated once