| Summary: | Remove double comma in source code for OPAC self-registration page | ||
|---|---|---|---|
| Product: | Koha | Reporter: | David Nind <david> |
| Component: | Architecture, internals, and plumbing | Assignee: | David Nind <david> |
| Status: | Needs Signoff --- | QA Contact: | Testopia <testopia> |
| Severity: | trivial | ||
| Priority: | P5 - low | ||
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 41735: Tidy OPAC self-registration page - fix qa warning
Bug 41735: Tidy OPAC self-registration page |
||
|
Description
David Nind
2026-01-29 18:06:30 UTC
Created attachment 192180 [details] [review] Bug 41735: Tidy OPAC self-registration page - fix qa warning opac/opac-memberentry.pl has a double comma in the source code. This generates a tidy error when the qa script is run. Test plan: 1. Review the patch and note that the double comma is removed. 2. Run the qa script - there should be no warnings or errors: qa Signed-off-by: David Nind <david@davidnind.com> Created attachment 192193 [details] [review] Bug 41735: Tidy OPAC self-registration page opac/opac-memberentry.pl has a double comma in the source code. Test plan: 1. Tidy the file: perl misc/devel/tidy.pl opac/opac-memberentry.pl 2. Generate a diff: git diff 3. Note the double comma. 4. Reset everything: git checkout opac/opac-memberentry.pl 5. Apply the patch. 6. Repeat steps 1 and 2 - no tidy changes made. 7. Run the qa script - there should be no warnings or errors: qa Signed-off-by: David Nind <david@davidnind.com> Updated the commit message with a "better" test plan. Running qa by itself doesn't identify the double comma. |