Bug 41735 - Remove double comma in source code for OPAC self-registration page
Summary: Remove double comma in source code for OPAC self-registration page
Status: Needs Signoff
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial
Assignee: David Nind
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2026-01-29 18:06 UTC by David Nind
Modified: 2026-01-29 18:58 UTC (History)
0 users

See Also:
GIT URL:
Initiative type: ---
Sponsorship status: ---
Comma delimited list of Sponsors:
Crowdfunding goal: 0
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 41735: Tidy OPAC self-registration page - fix qa warning (1.33 KB, patch)
2026-01-29 18:11 UTC, David Nind
Details | Diff | Splinter Review
Bug 41735: Tidy OPAC self-registration page (1.44 KB, patch)
2026-01-29 18:56 UTC, David Nind
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description David Nind 2026-01-29 18:06:30 UTC
The opac/opac-memberentry.pl has a double comma in the source code. This generates a tidy error when the qa script is run.

Line 280: branchcode  => $patron->branchcode,,

I'm not sure if this has any effect on how the page works.
Comment 1 David Nind 2026-01-29 18:11:54 UTC Comment hidden (obsolete)
Comment 2 David Nind 2026-01-29 18:56:56 UTC
Created attachment 192193 [details] [review]
Bug 41735: Tidy OPAC self-registration page

opac/opac-memberentry.pl has a double comma in the source code.

Test plan:
1. Tidy the file: perl misc/devel/tidy.pl opac/opac-memberentry.pl
2. Generate a diff: git diff
3. Note the double comma.
4. Reset everything: git checkout opac/opac-memberentry.pl
5. Apply the patch.
6. Repeat steps 1 and 2 - no tidy changes made.
7. Run the qa script - there should be no warnings or errors: qa

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 David Nind 2026-01-29 18:57:57 UTC
Updated the commit message with a "better" test plan. Running qa by itself doesn't identify the double comma.