The opac/opac-memberentry.pl has a double comma in the source code. This generates a tidy error when the qa script is run. Line 280: branchcode => $patron->branchcode,, I'm not sure if this has any effect on how the page works.
Created attachment 192180 [details] [review] Bug 41735: Tidy OPAC self-registration page - fix qa warning opac/opac-memberentry.pl has a double comma in the source code. This generates a tidy error when the qa script is run. Test plan: 1. Review the patch and note that the double comma is removed. 2. Run the qa script - there should be no warnings or errors: qa Signed-off-by: David Nind <david@davidnind.com>
Created attachment 192193 [details] [review] Bug 41735: Tidy OPAC self-registration page opac/opac-memberentry.pl has a double comma in the source code. Test plan: 1. Tidy the file: perl misc/devel/tidy.pl opac/opac-memberentry.pl 2. Generate a diff: git diff 3. Note the double comma. 4. Reset everything: git checkout opac/opac-memberentry.pl 5. Apply the patch. 6. Repeat steps 1 and 2 - no tidy changes made. 7. Run the qa script - there should be no warnings or errors: qa Signed-off-by: David Nind <david@davidnind.com>
Updated the commit message with a "better" test plan. Running qa by itself doesn't identify the double comma.