| Summary: | Cannot enable 'passive' mode in File Transports for FTP | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Martin Renvoize (ashimema) <martin.renvoize> |
| Component: | Staff interface | Assignee: | Martin Renvoize (ashimema) <martin.renvoize> |
| Status: | Pushed to main --- | QA Contact: | Paul Derscheid <paul.derscheid> |
| Severity: | critical | ||
| Priority: | P5 - low | CC: | gmcharlt, lucas, steven.raith |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | Unsponsored | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
26.05.00
|
|
| Circulation function: | |||
| Bug Depends on: | 39190 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 41798: Fix FTP passive mode not saving and add display indicator
Bug 41798: Fix FTP passive mode not saving and add display indicator Bug 41798: (QA follow-up) Add missing html filter |
||
|
Description
Martin Renvoize (ashimema)
2026-02-09 11:49:16 UTC
Created attachment 192743 [details] [review] Bug 41798: Fix FTP passive mode not saving and add display indicator The FTP passive mode setting was not being saved due to a typo in the parameter name ('passiv' instead of 'passive'). This fixes the typo and adds display of passive mode status in the transports table. Test plan: 1. Go to Administration > File transports 2. Click "New file transport" 3. Fill in the name (e.g., "Test FTP") 4. Change Transport to "FTP" 5. Set Passive mode to "Enabled (Recommended)" 6. Fill in required fields (host, username, etc.) and save 7. Edit the transport you just created 8. Verify Passive mode is still set to "Enabled" (not reverted to Disabled) 9. Return to the file transports list 10. Verify the Transport column shows "FTP (passive)" for this transport 11. Edit the transport and change Passive mode to "Disabled" 12. Save and return to the list 13. Verify the Transport column now shows just "FTP" (without the passive indicator) Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> Tiny patch to a critical bug.. self SO and QA. Created attachment 192912 [details] [review] Bug 41798: Fix FTP passive mode not saving and add display indicator The FTP passive mode setting was not being saved due to a typo in the parameter name ('passiv' instead of 'passive'). This fixes the typo and adds display of passive mode status in the transports table. Test plan: 1. Go to Administration > File transports 2. Click "New file transport" 3. Fill in the name (e.g., "Test FTP") 4. Change Transport to "FTP" 5. Set Passive mode to "Enabled (Recommended)" 6. Fill in required fields (host, username, etc.) and save 7. Edit the transport you just created 8. Verify Passive mode is still set to "Enabled" (not reverted to Disabled) 9. Return to the file transports list 10. Verify the Transport column shows "FTP (passive)" for this transport 11. Edit the transport and change Passive mode to "Disabled" 12. Save and return to the list 13. Verify the Transport column now shows just "FTP" (without the passive indicator) Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> Created attachment 192913 [details] [review] Bug 41798: (QA follow-up) Add missing html filter Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> Nice work everyone! Pushed to main for 26.05 |