| Summary: | ERM/Dialog_spec.ts leaves test data in DB | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
| Component: | Test Suite | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | Pushed to main --- | QA Contact: | Nick Clemens (kidclamp) <nick> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | lucas |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
26.05.00
|
|
| Circulation function: | |||
| Attachments: |
Bug 41831: Mock POST /packages in Dialog_spec.ts
Bug 41831: Mock POST /packages in Dialog_spec.ts Bug 41831: Mock POST /packages in Dialog_spec.ts |
||
|
Description
Jonathan Druart
2026-02-12 08:53:15 UTC
Created attachment 192999 [details] [review] Bug 41831: Mock POST /packages in Dialog_spec.ts ERM/Titles_spec.ts fails if run after ERM/Dialog_spec.ts because Dialog's "...created!" test create a package and does not delete it. 02:48:52 koha-1 | <failure message="Timed out retrying after 10000ms: Expected to find content: 'There are no packages created yet' within the element: <fieldset#resources_relationship.rows> but never did." type="AssertionError"><![CDATA[AssertionError: Timed out retrying after 10000ms: Expected to find content: 'There are no packages created yet' within the element: <fieldset#resources_relationship.rows> but never did. Test plan: 0. Do not apply the patch 1. yarn cypress run --spec t/cypress/integration/ERM/Dialog_spec.ts,t/cypress/integration/ERM/Titles_spec.ts => FAIL 2. Notice that one entry has been created in the DB table erm_eholdings_packages 3. Delete the DB entry: sudo koha-mysql kohadev -e 'DELETE FROM erm_eholdings_packages' 4. Apply this patch 5. Repeat 1 => SUCCESS 6. Notice that no new entry has been created in erm_eholdings_packages Created attachment 193010 [details] [review] Bug 41831: Mock POST /packages in Dialog_spec.ts ERM/Titles_spec.ts fails if run after ERM/Dialog_spec.ts because Dialog's "...created!" test create a package and does not delete it. 02:48:52 koha-1 | <failure message="Timed out retrying after 10000ms: Expected to find content: 'There are no packages created yet' within the element: <fieldset#resources_relationship.rows> but never did." type="AssertionError"><![CDATA[AssertionError: Timed out retrying after 10000ms: Expected to find content: 'There are no packages created yet' within the element: <fieldset#resources_relationship.rows> but never did. Test plan: 0. Do not apply the patch 1. yarn cypress run --spec t/cypress/integration/ERM/Dialog_spec.ts,t/cypress/integration/ERM/Titles_spec.ts => FAIL 2. Notice that one entry has been created in the DB table erm_eholdings_packages 3. Delete the DB entry: sudo koha-mysql kohadev -e 'DELETE FROM erm_eholdings_packages' 4. Apply this patch 5. Repeat 1 => SUCCESS 6. Notice that no new entry has been created in erm_eholdings_packages Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Created attachment 193012 [details] [review] Bug 41831: Mock POST /packages in Dialog_spec.ts ERM/Titles_spec.ts fails if run after ERM/Dialog_spec.ts because Dialog's "...created!" test create a package and does not delete it. 02:48:52 koha-1 | <failure message="Timed out retrying after 10000ms: Expected to find content: 'There are no packages created yet' within the element: <fieldset#resources_relationship.rows> but never did." type="AssertionError"><![CDATA[AssertionError: Timed out retrying after 10000ms: Expected to find content: 'There are no packages created yet' within the element: <fieldset#resources_relationship.rows> but never did. Test plan: 0. Do not apply the patch 1. yarn cypress run --spec t/cypress/integration/ERM/Dialog_spec.ts,t/cypress/integration/ERM/Titles_spec.ts => FAIL 2. Notice that one entry has been created in the DB table erm_eholdings_packages 3. Delete the DB entry: sudo koha-mysql kohadev -e 'DELETE FROM erm_eholdings_packages' 4. Apply this patch 5. Repeat 1 => SUCCESS 6. Notice that no new entry has been created in erm_eholdings_packages Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Pushed to main for 26.05.00. Nice work all! |