| Summary: | PA_CLASS does not show in fieldset ID on opac-memberentry.pl | ||
|---|---|---|---|
| Product: | Koha | Reporter: | David Cook <dcook> |
| Component: | OPAC | Assignee: | David Cook <dcook> |
| Status: | Passed QA --- | QA Contact: | Jonathan Druart <jonathan.druart> |
| Severity: | minor | ||
| Priority: | P5 - low | Keywords: | Academy |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 41970: Fix typo in pa_class in template
Bug 41970: Fix typo in pa_class in template Bug 41970: Fix typo in pa_class in template |
||
|
Description
David Cook
2026-03-03 01:30:48 UTC
Created attachment 194369 [details] [review] Bug 41970: Fix typo in pa_class in template This change fixes a typo from pa_loo to pa_class, so that the ID attribute of the fieldset is properly set when using PA_CLASS to group patron attributes. Test plan: 0. Set up two PA_CLASS values 1. Set up two patron attributes which are viewable/editable on the OPAC and assign them one class each 2. Go to http://localhost:8080/cgi-bin/koha/opac-memberentry.pl 3. Look at the HTML and note that fieldsets for both PA classes have the ID of "aai_" 4. Apply the patch 5. Reload the page http://localhost:8080/cgi-bin/koha/opac-memberentry.pl 6. Note that now the fieldsets have ID attributes of "aai_<PA_CLASS code>". 7. Rejoice as now it's easier to use Javascript and CSS and have valid HTML! Created attachment 194370 [details] [review] Bug 41970: Fix typo in pa_class in template This change fixes a typo from pa_loo to pa_class, so that the ID attribute of the fieldset is properly set when using PA_CLASS to group patron attributes. Test plan: 0. Set up two PA_CLASS values 1. Set up two patron attributes which are viewable/editable on the OPAC and assign them one class each 2. Go to http://localhost:8080/cgi-bin/koha/opac-memberentry.pl 3. Look at the HTML and note that fieldsets for both PA classes have the ID of "aai_" 4. Apply the patch 5. Reload the page http://localhost:8080/cgi-bin/koha/opac-memberentry.pl 6. Note that now the fieldsets have ID attributes of "aai_<PA_CLASS code>". 7. Rejoice as now it's easier to use Javascript and CSS and have valid HTML! Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Created attachment 194371 [details] [review] Bug 41970: Fix typo in pa_class in template This change fixes a typo from pa_loo to pa_class, so that the ID attribute of the fieldset is properly set when using PA_CLASS to group patron attributes. Test plan: 0. Set up two PA_CLASS values 1. Set up two patron attributes which are viewable/editable on the OPAC and assign them one class each 2. Go to http://localhost:8080/cgi-bin/koha/opac-memberentry.pl 3. Look at the HTML and note that fieldsets for both PA classes have the ID of "aai_" 4. Apply the patch 5. Reload the page http://localhost:8080/cgi-bin/koha/opac-memberentry.pl 6. Note that now the fieldsets have ID attributes of "aai_<PA_CLASS code>". 7. Rejoice as now it's easier to use Javascript and CSS and have valid HTML! Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> |