Summary: | encumbrance and expenditure not used in code | ||
---|---|---|---|
Product: | Koha | Reporter: | Nicole C. Engard <nengard> |
Component: | Acquisitions | Assignee: | Mathieu Saby <mathsabypro> |
Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
Severity: | major | ||
Priority: | P5 - low | CC: | chris, henridamien.laurent, jonathan.druart, koha, mathsabypro, mjr |
Version: | Main | ||
Hardware: | PC | ||
OS: | All | ||
URL: | cgi-bin/koha/admin/aqbudgets.pl?op=add_form&budget_period_id=1 | ||
Change sponsored?: | --- | Patch complexity: | String patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 9822 | ||
Attachments: |
[PATCH] Bug 4266: Hide encumbrance and expenditure
[SIGNED-OFF] Bug 4266: Hide Encumbrance and Expenditure Hide Encumbrance and Expenditure in aqbudgets.tt [SIGNED-OFF] Bug 4266: Hide Encumbrance and Expenditure in aqbudgets.tt Bug 4266: Hide Encumbrance and Expenditure in aqbudgets.tt |
Description
Chris Cormack
2010-05-21 01:25:09 UTC
Just bumping this up. These fields are confusing to those creating budgets and funds - and I would love to see these populated with data as orders are made (for reporting purposes). By the way there are fields in the aqbudgets table for these values that are empty: `budget_encumb` decimal(28,6) NULL default '0.00', `budget_expend` decimal(28,6) NULL default '0.00', This bug exists since 2010-02-25 - we still have fields on the fund page that seem not to be used anywhere. People expect functionality behind these fields. I confirm that we except impatiently the budget freeze in the page neworderempty.pl when the amount remaining is lower than encumbrance. Hello I want to make a patch hiding encumbrance and expenditure in templates for aqbudgets.pl. Do you agree with that? M. Saby That's fine with me. Created attachment 14870 [details] [review] [PATCH] Bug 4266: Hide encumbrance and expenditure Librarians are asked for Encumbrance and Expenditure when editing or creating a fund (admin/aqbudgets.pl). However these values are not yet taken into account by Koha. So it is misleading and must be corrected. This patch hides encumbrance and expenditure in template. To test : check encumbrance and expenditure are not asked anymore when editing or creating a fund. M. Saby Rennes 2 university Created attachment 14874 [details] [review] [SIGNED-OFF] Bug 4266: Hide Encumbrance and Expenditure Librarians are asked for Encumbrance and Expenditure when editing or creating a fund (admin/aqbudgets.pl). However these values are not yet taken into account by Koha. So it is misleading and must be corrected. This patch hides encumbrance and expenditure in template. To test : check encumbrance and expenditure are not asked anymore when editing or creating a fund. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> All tests pass Hi Mathieu, I agree it's irritating to have those fields when they have no use. But at the moment it's possible to add/edit and delete those information. It's saved to the database and people might have entered data there. My suggestion would be to set the elements to display:none; with CSS instead of deleting them. This way people can make them show up again easily using a bit of jquery. Would that work for you? Katrin Is the data saved to the database? I haven't tested recently, but my recollection is that that data never went anywhere - was never saved. Yes, the data is saved. I tested it. If the data is saved, I agree to rewrite the patch using "display:none". M. Saby Created attachment 15616 [details] [review] Hide Encumbrance and Expenditure in aqbudgets.tt new patch submitted. M. saby I reviewed this but I have not signed off because I am not comfortable with the style attribute being used without an id attribute that would allow it to be unhidden by IntranetUserCSS. I also feel that it should be a css file rather than inline, but the coding guidelines are silent on both points, so I'm leaving this as Needs Signoff for now, in case someone else is willing. Created attachment 16128 [details] [review] [SIGNED-OFF] Bug 4266: Hide Encumbrance and Expenditure in aqbudgets.tt Encumbrance and Expenditure fields are not taken into account by Koha, but the data are saved in database. This patch hide these fields in aqbudgets.tt To test : check if the 2 fields are hidden when creating a new fund. Signed-off-by: Owen Leonard <oleonard@myacpl.org> This could certainly be done in a few different ways both with CSS and JS, but this is a simple change and can be easily overridden: $("#budget_encumb,#budget_expend").closest("li").show(); I just found a BibLibre development using these 2 fields. I will try to rebase it against master. I switch this report to "in discussion" until I know what I can do. ok Jonathan but if Biblibre dev is proposed in Bugzilla, it won't be pushed into master before 3.12, more probably 3.14. So we will still need to hide the field for olders versions. M. Saby (In reply to comment #18) > ok Jonathan > but if Biblibre dev is proposed in Bugzilla, it won't be pushed into master > before 3.12, more probably 3.14. > So we will still need to hide the field for olders versions. > > M. Saby QA comment: Yes, it is relevant. I create a new report for the development (bug 9822). This patch hides 2 unused fields when creating/modifying a fund. Marked as Passed QA. Created attachment 16159 [details] [review] Bug 4266: Hide Encumbrance and Expenditure in aqbudgets.tt Encumbrance and Expenditure fields are not taken into account by Koha, but the data are saved in database. This patch hide these fields in aqbudgets.tt To test : check if the 2 fields are hidden when creating a new fund. Signed-off-by: Owen Leonard <oleonard@myacpl.org> This could certainly be done in a few different ways both with CSS and JS, but this is a simple change and can be easily overridden: $("#budget_encumb,#budget_expend").closest("li").show(); Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> This patch has been pushed to master. Pushed to 3.10.x and 3.8.x will be in 3.10.4 and 3.8.11 |