Bug 9822 - No alert appears on adding an order to a basket if the budget has exceeded
Summary: No alert appears on adding an order to a basket if the budget has exceeded
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: 3.14
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Jonathan Druart
QA Contact:
URL:
Keywords:
: 1822 6832 (view as bug list)
Depends on: 4266
Blocks:
  Show dependency treegraph
 
Reported: 2013-03-15 10:41 UTC by Jonathan Druart
Modified: 2015-01-13 17:19 UTC (History)
7 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Medium patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 9822: Alert on adding an order to a basket if budget has exceeded (10.04 KB, patch)
2013-03-15 10:46 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 9822: Alert on adding an order to a basket if budget has exceeded (10.04 KB, patch)
2013-03-18 14:56 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 9822: Alert on adding an order to a basket if budget has exceeded (8.31 KB, patch)
2013-03-18 15:08 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 9822: Alert on adding an order to a basket if budget has exceeded (8.37 KB, patch)
2013-03-19 08:09 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 9822: Alert on adding an order to a basket if budget has exceeded (8.42 KB, patch)
2013-06-18 08:18 UTC, Chris Cormack
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2013-03-15 10:41:09 UTC

    
Comment 1 Jonathan Druart 2013-03-15 10:46:03 UTC Comment hidden (obsolete)
Comment 2 Jonathan Druart 2013-03-15 11:03:51 UTC
*** Bug 1822 has been marked as a duplicate of this bug. ***
Comment 3 Koha Team University Lyon 3 2013-03-18 10:53:07 UTC
I create a new fund with warning fields (% and amount). I try all the combinations : the appropriate warning message appears. If you don't confirm the command, there's no problem. But, if you choose to confirm the command, there's a error " Software error:
Tag "" is not a valid tag. at /usr/share/perl5/MARC/File/SAX.pm line 92"
When I go back to the basket, the line is well recorded.
Comment 4 Jonathan Druart 2013-03-18 14:56:53 UTC Comment hidden (obsolete)
Comment 5 Jonathan Druart 2013-03-18 15:08:25 UTC Comment hidden (obsolete)
Comment 6 Koha Team University Lyon 3 2013-03-18 15:58:36 UTC
ok, everything works fine this time !
Comment 7 Jonathan Druart 2013-03-19 08:09:37 UTC Comment hidden (obsolete)
Comment 8 Chris Cormack 2013-06-18 08:18:45 UTC
Created attachment 19092 [details] [review]
Bug 9822: Alert on adding an order to a basket if budget has exceeded

2 DB fields are not used: aqbudgets.encumb and aqbudgets.expend.

This patch uses these fields in order to show a warning message if the
budget selected for an order has exceeded.

Test plan:
- Create a new active fund with at least 1 of both warning fields
  ('Warning at (%)' and 'Warning at (amount)').
- Create a new order for a basket with this new fund and a cost >
  warning amount defined for the fund (or using %).
- Save and check that a warning message appears
- Retry playing with all combinations of warning fields

Signed-off-by: Koha Team Lyon 3 <koha@univ-lyon3.fr>
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Comment 9 Galen Charlton 2013-10-30 15:11:09 UTC
Pushed to master.  Thanks, Jonathan!
Comment 10 simith.doliveira 2015-01-13 17:19:18 UTC
*** Bug 6832 has been marked as a duplicate of this bug. ***