Summary: | Acq > Manage suggestions contains untranslated strings | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | I18N/L10N | Assignee: | Katrin Fischer <katrin.fischer> |
Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
Severity: | normal | ||
Priority: | PATCH-Sent (DO NOT USE) | CC: | chris, oleonard |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
screenshot
Bug 4497: Make tabs for managing suggestions translatable Signed-off patch |
Description
Chris Cormack
2010-05-21 01:27:53 UTC
The first problem arises from the fact that the headings are coming straight from the database where they're stored as English strings. The script does "ucfirst(lc( $criteriumvalue))" on the database values ("ACCEPTED," etc). The second problem I don't understand. The string comes from this markup in the template: <input type="text" size="31" id="select-other_reason<!-- TMPL_VAR NAME="suggestiontype" -->" name="other_reason<!-- TMPL_VAR NAME="suggestiontype" -->" value="please note your reason here..." /> Why wouldn't the <input>'s value attribute be translated like any other? Problem still existing in master. Created attachment 4646 [details] [review] Bug 4497: Make tabs for managing suggestions translatable This patch makes the tabs on the manage suggestion page translatable. To test: - Create some suggestions in intranet or opac and manage them to make the different status tabs appear: accecpted, pending, checked, rejected - Apply patch, run 'perl translate update <languagecode>' - Check po file for string '%s %sPending %sAccepted %sChecked %sRejected %sAvailable %sOrdered%s %s%s %sNo name%s (%s)' - Translate it, save and run 'perl translate install <languagecode>' Tabs should now appear translated. Created attachment 4658 [details] [review] Signed-off patch I didn't do the whole translation procedure to test this patch, but it's a simple and straightforward template change that clearly addresses the issue. It still feels "wrong" to be storing English strings in the database and using template logic to evaluate them, but this patch solves the practical problem. Template changes, effecting translations, please test |