| Summary: | Show acquisition information when ordering from a suggestion | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Nicole C. Engard <nengard> | 
| Component: | Acquisitions | Assignee: | Katrin Fischer <katrin.fischer> | 
| Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> | 
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | abl, janet.mcgowan, martin.renvoize, nick, sandboxes, severine.queune | 
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| URL: | cgi-bin/koha/acqui/newordersuggestion.pl?booksellerid=1&basketno=1 | ||
| See Also: | http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11914 | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Crowdfunding goal: | 0 | 
| Patch complexity: | Small patch | Documentation contact: | |
| Documentation submission: | Text to go in the release notes: | 
       This enhancement adds the following fields to the suggestions selection table when adding a new order by selecting from a suggestion:
* library
* fund
* price
* quantity
* total 
 | 
        |
| Version(s) released in: | 
       19.05.00 
 | 
        
        Circulation function: | |
| Attachments: | 
              Bug 4833: Show acq information when selecting suggestion for order
               Bug 4833: Show acq information when selecting suggestion for order Bug 4833: Show acq information when selecting suggestion for order Bug 4833: (QA follow-up) Add budgetname to SearchSuggestion  | 
      ||
| 
 
        
          Description
        
        
          Nicole C. Engard
        
        
        
        
          2010-05-27 17:02:50 UTC
        
       
    Created attachment 86493 [details] [review] Bug 4833: Show acq information when selecting suggestion for order When adding an order line to a basket using the 'from a suggestion' feature, the list of accepted suggestions doesn't show any information from the acquisition are of the suggestions. This patch adds new columns to the list for: - library - fund - price - quantity - total To test: - Create several suggestions with - Empty acq values - A specific library, any library - Set acq values (fund, price, quantity) - Accept your suggestions - Create a new basket/order - Add an order line from accepted suggestions - Verify the list displays nicely with the new columns - Verify filters etc. still work ok Patch tested with a sandbox, by Séverine QUEUNE <severine.queune@bulac.fr> Created attachment 88272 [details] [review] Bug 4833: Show acq information when selecting suggestion for order When adding an order line to a basket using the 'from a suggestion' feature, the list of accepted suggestions doesn't show any information from the acquisition are of the suggestions. This patch adds new columns to the list for: - library - fund - price - quantity - total To test: - Create several suggestions with - Empty acq values - A specific library, any library - Set acq values (fund, price, quantity) - Accept your suggestions - Create a new basket/order - Add an order line from accepted suggestions - Verify the list displays nicely with the new columns - Verify filters etc. still work ok Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Everything seemed to be ok for me, thanks Cait ! (In reply to Séverine Queune from comment #4) > Everything seemed to be ok for me, thanks Cait ! Thx Severine! Created attachment 89095 [details] [review] Bug 4833: Show acq information when selecting suggestion for order When adding an order line to a basket using the 'from a suggestion' feature, the list of accepted suggestions doesn't show any information from the acquisition are of the suggestions. This patch adds new columns to the list for: - library - fund - price - quantity - total To test: - Create several suggestions with - Empty acq values - A specific library, any library - Set acq values (fund, price, quantity) - Accept your suggestions - Create a new basket/order - Add an order line from accepted suggestions - Verify the list displays nicely with the new columns - Verify filters etc. still work ok Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Thx for QA! (In reply to Katrin Fischer from comment #7) > Thx for QA! I am a little worried about the impact of this in a larger system - we are calling GetBudget for every suggestion - that is a DB hit per suggestion - I would rather see this info pulled in SearchSuggestion so that we maintain a single call for all the suggestions Can I get a second QA opinion here? (In reply to Nick Clemens from comment #8) > (In reply to Katrin Fischer from comment #7) > > Thx for QA! > > I am a little worried about the impact of this in a larger system - we are > calling GetBudget for every suggestion - that is a DB hit per suggestion - I > would rather see this info pulled in SearchSuggestion so that we maintain a > single call for all the suggestions > > Can I get a second QA opinion here? I am not sure how expensive it is, tbh, but I wouldn't expect a big number of accepted suggestions even in a bigger system. Maybe I am mistaken there. Just saying we only show a subset of data here. There are some other places where GetBudget is used: http://git.koha-community.org/gitweb/?p=koha.git&a=search&h=HEAD&st=grep&s=GetBudget%28 Talked to Nick, it makes sense, but I won't be able to fix probably for this release, sorry. Created attachment 89618 [details] [review] Bug 4833: (QA follow-up) Add budgetname to SearchSuggestion This patch adds the budgetname to the return of SearchSuggestion to improve performance. To test: - Same test plan as for the first patch - Verify fund names show in the table - Run t/db_dependent/Suggestions.t A late night attempt - Nick, can you check please? Awesome work all! Pushed to master for 19.05 Enhancement will not be backported to 18.11.x series.  |