Summary: | Improve controls for cloning and deleting MARC subfields | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Cataloging | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | chris, cmurdock, gmcharlt, koha.sekjal, nengard |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
URL: | /cgi-bin/koha/cataloguing/addbiblio.pl | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
Screenshot of proposed interface change
Proposed fix Screenshot of proposed update Addition of tag control icons, tag editor icon Revised fix [SIGNED-OFF] Follow-up to Bug 4868, Improve controls for cloning and deleting subfields |
Created attachment 2234 [details] [review] Proposed fix Includes changes to addbiblio.tmpl and authorities.tmpl I tested the patch, and it works. It also fixes bug 4867. :D You may want to change the label for "delete" to "unclone" though. The delete function will only delete a cloned subfield, or one that has a clone. It won't delete a noncloned one. I can forsee catalogers being confused by that. (In reply to comment #3) > You may want to change the label for "delete" to "unclone" though. The delete > function will only delete a cloned subfield, or one that has a clone. It won't > delete a noncloned one. In fact the "delete" link does two different things depending on the context: For cloned subfields, it really deletes. For non-mandatory, non-cloned subfields it will clear any contents from the field. A TODO for this interface change is to see whether those two contexts can be differentiated and an alternate icon displayed. Patch pushed. Why not have the same icon for cloning fields so that it's consistent for users? Created attachment 2475 [details]
Screenshot of proposed update
An additional update to add specific icons for cloning tags and deleting tags and for the tag editor link ("...").
Created attachment 2476 [details] [review] Addition of tag control icons, tag editor icon It seems the follow-up has never been pushed and needs rebasing for T::T now. I am moving to 'Does not apply' so it shows up in our reports. Created attachment 5022 [details] [review] Revised fix - Adding similar icons for cloning and deleting tags - Adding icon for the "Tag editor" links ("...") Created attachment 5027 [details] [review] [SIGNED-OFF] Follow-up to Bug 4868, Improve controls for cloning and deleting subfields - Adding similar icons for cloning and deleting tags - Adding icon for the "Tag editor" links ("...") Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Revised patch signed off. Template only change (even though cataloging/addbiblio.pl is touched, it's just in a stretch of HTML creation), easy to read. Marking as Passed QA Pushed the follow up please test The fix for this bug was published in the 3.4.5 release. If you were the reporter of this bug, please take time to verify the fix and update the status of this bug report accordingly. If the bug is fixed to your satisfaction, please close this report. |
Created attachment 2233 [details] Screenshot of proposed interface change When editing MARC tags in the biblio editor, repeatable subfields have two controls next to them, a "+" and a "-" for cloning and deleting subfields. These controls are currently marked up as text within <span>s, so they don't appear to be clickable: they're not highlighted as links and the cursor doesn't change to a pointer. I propose converting the <span>s to links and using icons instead of "+" and "-".