Summary: | Only 1 ISBN shows in non-XSL detail view | ||
---|---|---|---|
Product: | Koha | Reporter: | Nicole C. Engard <nengard> |
Component: | Searching | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
Severity: | minor | ||
Priority: | PATCH-Sent (DO NOT USE) | CC: | chris, julian.maurice |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
1 ISBN showing
2 ISBNs in MARC Proposed fix Revised for current HEAD signed-off patch with some small display fixes to opac view Proposed fix for 3.2.x Follow-up fix |
Created attachment 2237 [details]
2 ISBNs in MARC
This is true of the OPAC and the staff client. I'm assuming that as with authors, subjects, etc., in order to display multiple ISBNs we would need pull them directly from the MARC record. See GetMarcAuthors in Biblio.pm. Created attachment 2241 [details] [review] Proposed fix Fixed by doing a pretty dumb copy of GetMarcNotes. Functional, but it could be there is a more efficient way to do it given we want one repeating tag rather than a range of tags? Original patch will probably not apply cleanly anymore. A revised version of this fix can be found here: http://gitorious.org/koha-dev/koha-dev/commits/ps-Bug-4885-1-isbn-2010-06-10 Created attachment 2990 [details] [review] Revised for current HEAD Created attachment 2992 [details] [review] signed-off patch with some small display fixes to opac view Pushed, please test Created attachment 2994 [details] [review] Proposed fix for 3.2.x This bug is mentioned in: Fix for Bug 4885 - Only 1 ISBN shows in non-XSL detail view http://lists.koha-community.org/pipermail/koha-patches/2011-January/013600.html Fix for Bug 4885 - Only 1 ISBN shows in non-XSL detail view http://lists.koha-community.org/pipermail/koha-patches/2011-January/013603.html Fix for Bug 4885 - Only 1 ISBN shows in non-XSL detail view http://lists.koha-community.org/pipermail/koha-patches/2011-January/013604.html The fix for Bug 5551 has overwritten the changes to opac-detail.pl made for this bug. I'll send a new patch. Created attachment 3209 [details] [review] Follow-up fix Pushed please test This bug is mentioned in: Follow-up fix for Bug 4885 - Only 1 ISBN shows in non-XSL detail view http://lists.koha-community.org/pipermail/koha-patches/2011-February/013928.html Follow-up fix for Bug 4885 - Only 1 ISBN shows in non-XSL detail view http://lists.koha-community.org/pipermail/koha-patches/2011-February/013923.html |
Created attachment 2236 [details] 1 ISBN showing In the staff client with XSLT off only 1 ISBN shows on the results screen and on the bib record. It should show all ISBNs. See attached.