Description
Katrin Fischer
2010-06-24 13:13:01 UTC
Still valid :( Hi Kyle, is there a reason you removed me as assignee from this bug? I know it's an old bug - but I have some code that would have worked before hourly loans an I hoped to look into this again before end of August. Katrin, I was trying to re-assign it to myself, but it looks like I only switched it to the default assignee. I was planning on taking a crack at this. Katrin, I was trying to re-assign it to myself, but it looks like I only switched it to the default assignee. I was planning on taking a crack at this, but I have re-assigned it back to you in case you get to it first. Created attachment 11507 [details] [review] Bug 4906 - Problem with grace period calculation and fine intervals >1 This patch adds the system preference FinesIncludeGracePeriod which allows the library the choice to include the grace period when calculating a fine ( Koha's current behavior ) or to ingore the grace period for the purposes of fines calculation. It is set by default to preserve the current behavior. Created attachment 11508 [details] [review] Bug 4906 - Problem with grace period calculation and fine intervals >1 This patch adds the system preference FinesIncludeGracePeriod which allows the library the choice to include the grace period when calculating a fine ( Koha's current behavior ) or to ingore the grace period for the purposes of fines calculation. It is set by default to preserve the current behavior. Applying: Bug 4906 - Problem with grace period calculation and fine intervals >1 /home/srikanth/Projects/Koha/koha/.git/rebase-apply/patch:17: trailing whitespace. if ( C4::Context->preference('FinesIncludeGracePeriod') ) { error: patch failed: C4/Overdues.pm:264 error: C4/Overdues.pm: patch does not apply error: patch failed: installer/data/mysql/sysprefs.sql:374 error: installer/data/mysql/sysprefs.sql: patch does not apply error: patch failed: installer/data/mysql/updatedatabase.pl:5635 error: installer/data/mysql/updatedatabase.pl: patch does not apply Patch failed at 0001 Bug 4906 - Problem with grace period calculation and fine intervals >1 When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". Patch left in /tmp/Bug-4906---Problem-with-grace-period-calculation-a-w6Gl8z.patch Created attachment 13515 [details] [review] Bug 4906 - Problem with grace period calculation and fine intervals >1 This patch adds the system preference FinesIncludeGracePeriod which allows the library the choice to include the grace period when calculating a fine ( Koha's current behavior ) or to ingore the grace period for the purposes of fines calculation. It is set by default to preserve the current behavior. Applying: Bug 4906 - Problem with grace period calculation and fine intervals >1 error: patch failed: installer/data/mysql/updatedatabase.pl:6055 error: installer/data/mysql/updatedatabase.pl: patch does not apply Patch failed at 0001 Bug 4906 - Problem with grace period calculation and fine intervals >1 When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". Patch left in /tmp/Bug-4906---Problem-with-grace-period-calculation-a-GyPe81.patch Created attachment 13570 [details] [review] [SIGNED-OFF]Bug 4906 - Problem with grace period calculation and fine intervals >1 This patch adds the system preference FinesIncludeGracePeriod which allows the library the choice to include the grace period when calculating a fine ( Koha's current behavior ) or to ingore the grace period for the purposes of fines calculation. It is set by default to preserve the current behavior. Signed-off-by: Srikanth Dhondi <srikanth@catalyst.net.nz> I think the system preference is called "FinesForGracePeriod" not "FinesIncludeGracePeriod". Could you confirm that? (In reply to comment #8) > Created attachment 13515 [details] [review] > Bug 4906 - Problem with grace period calculation and fine intervals >1 > > This patch adds the system preference FinesIncludeGracePeriod which > allows the library the choice to include the grace period when calculating > a fine ( Koha's current behavior ) or to ingore the grace period for > the purposes of fines calculation. It is set by default to preserve the > current behavior. Created attachment 13574 [details] [review] Bug 4906 - Problem with grace period calculation and fine intervals >1 - Followup You are correct. Thanks for catching that! (In reply to comment #11) > I think the system preference is called "FinesForGracePeriod" not > "FinesIncludeGracePeriod". Could you confirm that? QA comment: the QA for this patch should not be a problem, because it's a small one. BUT I think it does not solve the problem katrin described in his initial description: if you set FinesIncludeGracePeriod, then there is no change in the behaviour, and you will still have the same result. The problem Katrin pointed in his description is the fact that the fine is placed *at the end* of each fine interval, not at the beginning. Your patch is related to another feature I think. Katrin, do you agree that this patch does not solve the problem you describe (it's a valuable ENH though, but maybe in another bug ?) I think what Paul stated is the bug Katrin described, the first fine should be charged after due-date + graceperiod. Now it is charged after due-date + grace + fine-interval. (In reply to comment #15) > I think what Paul stated is the bug Katrin described, the first fine should > be charged after due-date + graceperiod. Now it is charged after due-date + > grace + fine-interval. exactly ! QA: Looking at this one now. Created attachment 15969 [details] [review] Bug 4906 - Problem with grace period calculation and fine intervals >1 This patch adds the system preference FinesIncludeGracePeriod which allows the library the choice to include the grace period when calculating a fine ( Koha's current behavior ) or to ingore the grace period for the purposes of fines calculation. It is set by default to preserve the current behavior. Signed-off-by: Srikanth Dhondi <srikanth@catalyst.net.nz> Rebased March 8, 2013. Included renaming pref. (marcelr) Changing the title of this report and opening a new bug for the original one. Created attachment 15970 [details] [review] Bug 4906: Allow fine calculation to exclude grace period This patch adds the system preference FinesIncludeGracePeriod which allows the library the choice to include the grace period when calculating a fine ( Koha's current behavior ) or to ignore the grace period for the purposes of fines calculation. It is set by default to preserve the current behavior. Signed-off-by: Srikanth Dhondi <srikanth@catalyst.net.nz> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Rebased March 8, 2013. Included renaming pref. Works as advertised. Renamed the bug title and opened a new report for the original bug. QA Comment: Kyle probably should have opened a new report for this development some time ago. I did now the other way around. Bug 9768 is the new old one :) This patch works as advertised. Code looks good to me. Passed QA Can someone who tested this explain in a few words where the difference is between Kyle's change and what the bug was intended to do? I am a bit confused at this point :) I think Paul explains it in comment 14. (In reply to comment #22) > Can someone who tested this explain in a few words where the difference is > between Kyle's change and what the bug was intended to do? I am a bit > confused at this point :) This patch has been pushed to master. |