Summary: | Filling an order page with no budget defined causes a 500 error | ||
---|---|---|---|
Product: | Koha | Reporter: | Robin Sheat <robin> |
Component: | Acquisitions | Assignee: | Robin Sheat <robin> |
Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
Severity: | normal | ||
Priority: | PATCH-Sent (DO NOT USE) | CC: | chris, katrin.fischer, nengard, paul.poulain, wizzyrea |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3616 | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Bug Depends on: | 6994 | ||
Bug Blocks: | |||
Attachments: |
proposed patch
Bug 5072 - prevent creating new orders if there are no valid budgets Bug 5072 : Template changes [SIGNED-OFF] Bug 5072 : Template changes [SIGNED-OFF] Bug 5072 - prevent creating new orders if there are no valid budgets proposed patch (passed QA) proposed patch (passed QA) |
Description
Robin Sheat
2010-07-29 02:48:57 UTC
Created attachment 2433 [details] [review] proposed patch *** Bug 5061 has been marked as a duplicate of this bug. *** Colin commented on bug 5061, that this bug is also related to 3616. Colin: 'The bug is related to 3616 but needs a separate fix. In Acquisitions.pm the error message is issued via a die. die is not a user friendly way to handle error conditions.' While I haven't tested it, I suspect that #3616 is solved by this as well, as this corrects the workflow to prevent the user getting to the point of trying to enter a new order if it would fail further down the track. Hi Robin, your patch contains changes to a .gitignore file. Can you please resubmit without it? Created attachment 4802 [details] [review] Bug 5072 - prevent creating new orders if there are no valid budgets On the basket editing screen, the links to add orders to a basket are hidden unless a valid fund is available. Created attachment 4803 [details] [review] Bug 5072 : Template changes Created attachment 4804 [details] [review] [SIGNED-OFF] Bug 5072 : Template changes Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Created attachment 4805 [details] [review] [SIGNED-OFF] Bug 5072 - prevent creating new orders if there are no valid budgets On the basket editing screen, the links to add orders to a basket are hidden unless a valid fund is available. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Retested this on current master. If you try to save a order in acquisitions you get an alert now that you have to choose a fund first. If you have no funds defined, you can't save, but you don't get a perl error message any longer. With patch you can not add order line to a basket before you have created a fund and a budget. The patch does not check if you are allowed to spend on that budget. But it's an improvement over current behaviour. Created attachment 4818 [details] [review] proposed patch (passed QA) Created attachment 4819 [details] [review] proposed patch (passed QA) QA comment: * patch addresses the problem * The 2nd patch also contains an undocumented fix in POD doc of the .pm. Thanks Katrin for fixing, shame for not saying it. Outside from this -very minor- comment, passed QA (+no DB change) Pushed please test *** Bug 4111 has been marked as a duplicate of this bug. *** This works, but there is a small follow up to prevent the message from showing up on the 'order from suggestion' page (bug 6994) There have been no further reports of problems so I am marking this bug resolved. |