Bug 5159

Summary: HomeOrHoldingBranch syspref description misleading
Product: Koha Reporter: Jane Wagner <jwagner>
Component: CirculationAssignee: Kyle M Hall <kyle.m.hall>
Status: CLOSED FIXED QA Contact: Bugs List <koha-bugs>
Severity: normal    
Priority: P5 - low CC: gmcharlt, veron
Version: Main   
Hardware: All   
OS: All   
See Also: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10079
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10754
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Description Jane Wagner 2010-08-19 17:02:04 UTC 
The old syspref description for HomeOrHoldingBranch implies it's only used with Independent Branches on:

"Used by Circulation to determine which branch of an item to check with independent branches on, and by search to determine which branch to choose for availability."

However, it seems to also affect transfers in systems where Independent Branches is not on (if set to holding branch, a checkin doesn't trigger a transfer message back to the owning branch).  And it's also used by C4/Search.pm to control the branch description that shows in search results/record displays.

The 3.2 syspref description is: Use the checkout and fines rules of (equiv description of home or holding branch)
NOTE: This is older than CircControl, but used by some parts of Koha. It will be removed soon. 

First question, then, is whether there are plans to remove this syspref, as implied by the 3.2 description?  And if so, what's going to happen to the other areas that it's now controlling?

This came up in a discussion on the IRC about Bug 3262 -- the section of Search.pm that controls what library branch displays is in turn controlled by this syspref.
Comment 1 Owen Leonard 2011-10-25 16:38:58 UTC 
Is this bug still valid? The current wording:

"Use the checkout and fines rules of [ the library the item was checked out from | the library the item is from ]"
Comment 2 Marc Véron 2015-12-20 17:13:23 UTC 
Still valid?
Comment 3 Katrin Fischer 2019-05-04 13:00:25 UTC 
(In reply to Owen Leonard from comment #1)
> Is this bug still valid? The current wording:
> 
> "Use the checkout and fines rules of [ the library the item was checked out
> from | the library the item is from ]"

The description is different now than at the time the bug was filed. Marking RESOLVED FIXED.