Summary: | comments shouldn't show patron's full name | ||
---|---|---|---|
Product: | Koha | Reporter: | Nicole C. Engard <nengard> |
Component: | OPAC | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Jonathan Druart <jonathan.druart> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | adrien.saurat, dschust1, jonathan.druart, koha.sekjal, paul.poulain |
Version: | 3.8 | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
Proposed fix
[SIGNED-OFF] Bug 5503 - comments shouldn't show patron's full name Proposed fix, revised Bug 5503 [REVISED] comments shouldn't show patron's full name Bug 5503 [REVISED] comments shouldn't show patron's full name [SIGNED-OFF] Bug 5503 [REVISED] comments shouldn't show patron's full name [SIGNED-OFF] Bug 5503 [REVISED] comments shouldn't show patron's full name |
Description
Nicole C. Engard
2010-12-15 15:25:09 UTC
See also http://wiki.koha-community.org/wiki/OPAC_Comments_RFC, specifically this proposal: In the OPAC the name displays currently would like to change that to a system preference offering display choices: o First and last name, First name, Last name, First name with Last Initial, none, nick, or login ID. Just for the record: In file "opac-details.tmpl", line 692 : <h5> Comment by <!-- TMPL_VAR NAME="title" --> <!-- TMPL_VAR NAME="firstname" --> <!-- TMPL_VAR NAME="surname" --> </h5> This is something I could probably tackle today (we'll see if I get distracted with other work). *** This bug has been marked as a duplicate of bug 5897 *** This is not a duplicate - this asks for an enhancement to the preference about showing names - allowing the library to choose how the name displays. Created attachment 6844 [details] [review] Proposed fix Adding a few choices for what information can be displayed alongside comments in the OPAC: - nothing - full name - first name - last name - first name and last name first initial - username Created attachment 6845 [details] [review] [SIGNED-OFF] Bug 5503 - comments shouldn't show patron's full name Adding a few choices for what information can be displayed alongside comments in the OPAC: - nothing - full name - first name - last name - first name and last name first initial - username Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Tested by choosing each choice and previewing an individual title with a comment and confirming the name was displayed properly. Then choosing each option and prevewing the recent comments page. All tests passed. Mostly a template change, making use of SWITCH (which we may not have access to in Perl 5.10, but we do in T:T!). Provides a plethora of options, and is easily extensible should need others. Marking Passed QA Changing severity, it's more an ENH than a bugfix QA comment Well, it seems this patch has not be tested. When upgrading, I get a mySQL error: [Tue Jan 10 23:19:12 2012] updatedatabase.pl: DBD::mysql::db do failed: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 's identity is presented alongside comments in the OPAC', `type` = 'Choice' WHER' at line 1 at /home/paul/koha.dev/koha-community/installer/data/mysql/updatedatabase.pl line 4610. [Tue Jan 10 23:19:12 2012] updatedatabase.pl: DBD::mysql::db do failed: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 's identity is presented alongside comments in the OPAC', `type` = 'Choice' WHER' at line 1 at /home/paul/koha.dev/koha-community/installer/data/mysql/updatedatabase.pl line 4611. Looking at the code, I see : $dbh->do(" UPDATE `koha`.`systempreferences` SET `value` = 'none', `options` = 'none|full|first|surname|firstandinitial|username', `explanation` = 'Choose how a commenter\'s identity is presented alongside comments in the OPAC', `type` = 'Choice' WHERE `systempreferences`.`variable` = 'ShowReviewer' AND `systempreferences`.`variable` = 0"); Should be commenter''s I think. Also note, as you'll have to send a follow-up that ` should be removed from table & column names, it's a mysql-ism thx Created attachment 7202 [details] [review] Proposed fix, revised The database name is mentionned in the updatedatabase, my DB has a different name and the update failed. Would be good to replace `koha`.`systempreferences` by systempreferences (and remove the others ` characters). I'll get back to sign off asap, but as I was testing the pre-patch fonctionnality, I couldn't see the commenter's name in OPAC even when the ShowReviewer systempreference was activated. Am I missing something needed to activate this? Created attachment 7632 [details] [review] Bug 5503 [REVISED] comments shouldn't show patron's full name Adding a few choices for what information can be displayed alongside comments in the OPAC: - nothing - full name - first name - last name - first name and last name first initial - username Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Tested by choosing each choice and previewing an individual title with a comment and confirming the name was displayed properly. Then choosing each option and prevewing the recent comments page. All tests passed. Owen, Does the revised patch need a sign off again? It says I signed off on the patch that is attached so I'm confused. Nicole (In reply to comment #13) > Does the revised patch need a sign off again? It says I signed off on the patch > that is attached so I'm confused. Sorry, that must have been my mistake during preparing the patch. The patch does include (minor) revisions, so another signoff is in order. Bug 5503 [REVISED] comments shouldn't show patron's full name Apply? [yn] y Applying: Bug 5503 [REVISED] comments shouldn't show patron's full name error: patch failed: installer/data/mysql/updatedatabase.pl:4678 error: installer/data/mysql/updatedatabase.pl: patch does not apply Patch failed at 0001 Bug 5503 [REVISED] comments shouldn't show patron's full name When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". Patch left in /tmp/Bug-5503-REVISED-comments-shouldnt-show-patrons-fu-tt1qCP.patch nengard@kohavm:~/kohaclone$ Created attachment 7900 [details] [review] Bug 5503 [REVISED] comments shouldn't show patron's full name Adding a few choices for what information can be displayed alongside comments in the OPAC: - nothing - full name - first name - last name - first name and last name first initial - username Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Tested by choosing each choice and previewing an individual title with a comment and confirming the name was displayed properly. Then choosing each option and prevewing the recent comments page. All tests passed. Okay, yeah, that still says signed off. Hm. Anyway, the conflict was a garden-variety updatedatabase conflict. The new patch has been rebased against current master. Created attachment 7902 [details] [review] [SIGNED-OFF] Bug 5503 [REVISED] comments shouldn't show patron's full name Adding a few choices for what information can be displayed alongside comments in the OPAC: - nothing - full name - first name - last name - first name and last name first initial - username Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Tested by choosing each choice and previewing an individual title with a comment and confirming the name was displayed properly. Then choosing each option and prevewing the recent comments page. All tests passed. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Ran all tests again and it works as explained. Created attachment 7968 [details] [review] [SIGNED-OFF] Bug 5503 [REVISED] comments shouldn't show patron's full name Rebased patch (conflicts in updatedatabase.pl) marked as Passed QA There have been no further reports of problems so I am marking this bug resolved. |