Summary: | Can't delete list from second page of results | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Lists | Assignee: | Chris Cormack <chris> |
Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
Severity: | normal | ||
Priority: | PATCH-Sent (DO NOT USE) | CC: | chris, koha.sekjal, nengard, smoreland |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
URL: | /cgi-bin/koha/opac-shelves.pl?display=privateshelves&shelfoff=2 | ||
See Also: | http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6279 | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Bug Depends on: | |||
Bug Blocks: | 6792 | ||
Attachments: |
Bug 5524 : Cant delete list from the second page of lists
Bug 5524 : Cant delete list from the second page of lists Bug 5524 - Follow up fixing deleting lists in OPAC Signed-off patches, squashed |
Description
Owen Leonard
2010-12-20 14:34:43 UTC
*** Bug 6279 has been marked as a duplicate of this bug. *** Working on this now I see the problem, the list only fetches 20, and we aren't passing the offset in, so it fetches 20, and the 1 you want to delete isnt part of that 20. Working on a fix now Created attachment 5154 [details] [review] Bug 5524 : Cant delete list from the second page of lists This patch seems to work, but has one minor bug. The two instances of this: <input type="hidden" name="shelfoff" value="[% shelfoff %]"> ...should be: <input type="hidden" name="shelfoff" value="[% shelfoff %]" /> Could a follow-up patch include the same fix for the OPAC as well? Created attachment 5189 [details] [review] Bug 5524 : Cant delete list from the second page of lists Fixed patch for staff side, follow up patch for opac on its way Created attachment 5191 [details] [review] Bug 5524 - Follow up fixing deleting lists in OPAC Created attachment 5212 [details] [review] Signed-off patches, squashed Simple change, mostly template, with the addition of a variable to the Perl. Easy to read, marking as Passed QA Pushed please test The fix for this bug was published in the 3.4.5 release. If you were the reporter of this bug, please take time to verify the fix and update the status of this bug report accordingly. If the bug is fixed to your satisfaction, please close this report. |