Summary: | Change cart markup to allow for easier icon styling | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | OPAC | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
Severity: | enhancement | ||
Priority: | PATCH-Sent (DO NOT USE) | CC: | chris, julian.maurice, magnus, nengard |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
Proposed change
signed-off patch |
Description
Owen Leonard
2011-01-07 16:54:16 UTC
Shouldn't we do the same for Lists? > Shouldn't we do the same for Lists? This patch arises as a result of my work trying to get Bug 3719 working ("Create syspref to allow sites to rename OPAC Cart") so it seeks to address that specific case. Do you hear requests to similarly change the style of the Lists button? I have not as of yet, but that said, if you're touching that code it seems like it would make sense to just make both buttons customizable. Created attachment 2966 [details] [review] Proposed change Replacing inline cart image with a span with a unique ID. Adding styling to the deafult CSS to give that span a background of the same cart image as before. Custom CSS can override this with a different image. Example for OPACUserCSS preference: #cartmenulink span#carticon { background-image : url("/opac-tmpl/prog/famfamfam/silk/basket.png"); width:16px; height:16px; } This bug is mentioned in: Fix for Bug 5593, Change cart markup to allow for easier icon styling http://lists.koha-community.org/pipermail/koha-patches/2011-January/013553.html Created attachment 3355 [details] [review] signed-off patch Pushed, please test |