Bug 3719 - Create syspref to allow sites to rename OPAC Cart
Summary: Create syspref to allow sites to rename OPAC Cart
Status: CLOSED WONTFIX
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: master
Hardware: PC All
: PATCH-Sent (DO NOT USE) enhancement with 10 votes (vote)
Assignee: Jane Wagner
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-10-20 02:49 UTC by Jane Wagner
Modified: 2015-10-05 10:09 UTC (History)
7 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Screenshot of OPAC with rename Cart syspref active (67.67 KB, image/jpeg)
2009-10-20 14:49 UTC, Chris Cormack
Details
main patch file (24.14 KB, patch)
2010-02-03 18:38 UTC, Chris Cormack
Details | Diff | Splinter Review
second part of the patch (2.26 KB, patch)
2010-02-03 18:38 UTC, Chris Cormack
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Cormack 2010-05-21 01:14:11 UTC


---- Reported by jwagner@ptfs.com 2009-10-20 14:49:28 ----

Created an attachment
Screenshot of OPAC with rename Cart syspref active

Some sites don't like the name Cart for the shopping cart/bookbag feature in the OPAC.  They would prefer a name like Bookbag or Personal Shelf, but changing the name requires modifying a lot of template files (9 files, if I've found them all).  I have not been successful at making the change to every place the Cart label is found with jquery statements.  Therefore, I've created a syspref named opacbookbagName and modified the various templates to use its value.  It will default to Cart at installation, but sites can change it as desired.



---- Additional Comments From jwagner@ptfs.com 2009-10-20 15:47:38 ----

Patch sent October 20, 2009.



---- Additional Comments From nengard@gmail.com 2009-10-20 20:48:08 ----

With this patch - what happens with the Image used for the Cart? I assume the image doesn't change - just the label - but was curious.



---- Additional Comments From jwagner@ptfs.com 2009-10-21 11:47:42 ----

Nicole, this patch doesn't try to replace the shopping cart image.  I have tried that on a couple of systems, but it gets complicated.  There are two or three cart image files of different sizes, and I only had one alternative image.  I figure we can live with the cart image if the text is changeable.



---- Additional Comments From jwagner@ptfs.com 2009-10-23 18:30:50 ----

Sent an update patch on October 23 to modify a couple of other places that I missed in the first one.  Thanks to Owen Leonard for JavaScript help!




---- Additional Comments From jwagner@ptfs.com 2010-02-03 18:38:08 ----

Created an attachment
main patch file





---- Additional Comments From jwagner@ptfs.com 2010-02-03 18:38:29 ----

Created an attachment
second part of the patch





---- Additional Comments From nengard@gmail.com 2010-02-06 23:31:40 ----

Was this patch pushed? I don't see it in the current HEAD.



---- Additional Comments From jwagner@ptfs.com 2010-02-08 12:48:38 ----

It hasn't made it into head yet.  Per Owen, I need to do some cleanup in the templates; I'll send a revised version when I get a chance.




---- Additional Comments From jwagner@ptfs.com 2010-05-12 13:48:09 ----

The fix for this bug (in ptfs-harley) can be pulled from the public git repository at http://github.com/Koha-PTFS, branch http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3719




--- Bug imported by chris@bigballofwax.co.nz 2010-05-21 01:14 UTC  ---

This bug was previously known as _bug_ 3719 at http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3719
Imported an attachment (id=1536)
Imported an attachment (id=1537)
Imported an attachment (id=1538)

Unknown operating system Windows 2000. Setting to default OS "All".
Actual time not defined. Setting to 0.0
The original reporter of this bug does not have
   an account here. Reassigning to the person who moved
   it here: chris@bigballofwax.co.nz.
   Previous reporter was jwagner@ptfs.com.
The original assignee of this bug does not have
   an account here. Reassigning to the default assignee
   for the component, chris@bigballofwax.co.nz.
   Previous assignee was jwagner@ptfs.com.
Bug reassigned, setting status to "NEW".
   Previous status was "ASSIGNED".
The original submitter of attachment 1536 [details] is unknown.
   Reassigning to the person who moved it here: chris@bigballofwax.co.nz.
The original submitter of attachment 1537 [details] [review] is unknown.
   Reassigning to the person who moved it here: chris@bigballofwax.co.nz.
The original submitter of attachment 1538 [details] [review] is unknown.
   Reassigning to the person who moved it here: chris@bigballofwax.co.nz.

Comment 1 lmschatt 2010-11-16 19:12:03 UTC
It would be really nice to be able to change the cart icon as well. If the name is changed to Bookbag, the shopping cart icon doesn't make sense and confuses patrons.
Comment 2 Jane Wagner 2010-11-16 19:18:44 UTC
As I found when I was changing the name, the path to the cart image is also hardcoded in several places.  Some of them don't obey the stylesheet, so changing the image there isn't a solution unless those sections of code are fixed.

A project for later....
Comment 3 Owen Leonard 2011-01-05 20:19:33 UTC
A working version of this change can be found in the ip-bug-3719-cart-syspref-2010-12-31 branch at http://gitorious.org/koha-dev/koha-dev

This branch cherry-picks the functionality added in ptfs/Bug3719 and adds some
corrections.
Comment 4 Katrin Fischer 2011-03-19 08:59:54 UTC
This system preference breaks translation of the cart button. It's only possible to set one term in one language. At the moment the cart button name is handled by po files and can be properly for every language.
Comment 5 Paul Poulain 2011-04-08 15:23:47 UTC
I strongly don't like the idea of a syspref for this kind of changes ! It means every library that will want a small change in terminology (like patron vs member vs borrower) will get a syspref. I think this kind of feature should be a local change.
And it can be achieved with the translation tool : create a en_library.pl file, "translate" shopping cart to what you want, generate en_library language, and activate it (and unactivate "english")