| Summary: | Z39.50 search from search results not parsing query correctly | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Ian Walls <koha.sekjal> |
| Component: | Searching | Assignee: | Galen Charlton <gmcharlt> |
| Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | gabrielle.dusseault, gaetan.boisson, gitbot, josef.moravec, m.de.rooy, sandboxes, tomascohen, wizzyrea |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 10742 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 5645: improve converting simple search to Z39.50 search
Bug 5645: improve converting simple search to Z39.50 search Bug 5645: improve converting simple search to Z39.50 search |
||
|
Description
Ian Walls
2011-01-20 19:13:59 UTC
*** Bug 7471 has been marked as a duplicate of this bug. *** Confirmed, still a bug. See Liz Rea's screenshot from bug 7471 : http://screencast.com/t/Zi2saYeF9sz (In reply to comment #0) > This is not a problem for two or more separate search fields. I still see this bug in master as of 3.12 beta1, and I don't find the above statement to be true. *** Bug 10034 has been marked as a duplicate of this bug. *** The patch for bug 10742 fixes the case when the main search returns no results. I will shortly be attaching a patch that fixes this when the main search *does* return results. Created attachment 20857 [details] [review] Bug 5645: improve converting simple search to Z39.50 search This patch builds on the patch for bug 10742 by ensuring that when a search initiated from the staff interface simple search returns results, if you click on the Z39.50 search button, the search form is populated with the search string without "kw,wrdl". To test: [1] Perform a search in the staff interface that will return results. [2] Click the Z39.50 search button. [3] Observe that the search string appears in the title field in the Z39.50 search form, but with a prefix of "kw,wrdl". [4] Apply the patch. [5] Repeat steps 1-2. This time, the search string appears without the index prefix. This will make the Z39.50 search much more likely to work. [6] Repeat steps 1-2, but with a search that does *not* return any hits in the Koha database. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Created attachment 21365 [details] [review] Bug 5645: improve converting simple search to Z39.50 search This patch builds on the patch for bug 10742 by ensuring that when a search initiated from the staff interface simple search returns results, if you click on the Z39.50 search button, the search form is populated with the search string without "kw,wrdl". To test: [1] Perform a search in the staff interface that will return results. [2] Click the Z39.50 search button. [3] Observe that the search string appears in the title field in the Z39.50 search form, but with a prefix of "kw,wrdl". [4] Apply the patch. [5] Repeat steps 1-2. This time, the search string appears without the index prefix. This will make the Z39.50 search much more likely to work. [6] Repeat steps 1-2, but with a search that does *not* return any hits in the Koha database. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Looks good to me. Works as advertised. No qa complaints. Passed QA This was missing a sign off when it got QA'd. I am switching back to 'needs signoff' so it gets on the radar of testers. Please switch to 'passed QA' if testing is successful. Patch tested with a sandbox, by Josef Moravec <josef.moravec@gmail.com> Created attachment 21705 [details] [review] Bug 5645: improve converting simple search to Z39.50 search This patch builds on the patch for bug 10742 by ensuring that when a search initiated from the staff interface simple search returns results, if you click on the Z39.50 search button, the search form is populated with the search string without "kw,wrdl". To test: [1] Perform a search in the staff interface that will return results. [2] Click the Z39.50 search button. [3] Observe that the search string appears in the title field in the Z39.50 search form, but with a prefix of "kw,wrdl". [4] Apply the patch. [5] Repeat steps 1-2. This time, the search string appears without the index prefix. This will make the Z39.50 search much more likely to work. [6] Repeat steps 1-2, but with a search that does *not* return any hits in the Koha database. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Changing status with reference to comment8 Pushed to master. This patch has been pushed to 3.12.x, will be in 3.12.7. Thanks Galen! |