Description
Nicole C. Engard
2011-01-31 15:17:41 UTC
This would still be a cool feature and probably not that hard to implement since the searches all have RSS feeds already. *** Bug 11968 has been marked as a duplicate of this bug. *** Created attachment 28881 [details] [review] 5672 Gives RSS icons to search history This patch adds an extra column to the table for the search history (this session and previous searches) with RSS icons for each search. Test plan: * Verify that there is no RSS icons for saved searches in opac * Install the patch * Verify that there is no RSS icons for saved searches and searches for the current session in Opac. * Test that the RSS links produce the expected result. Note: I left out authority searches since I have very little experience with authority searches and didn't feel I could test it properly. Created attachment 28905 [details] [review] [SIGNED-OFF] 5672 Gives RSS icons to search history This patch adds an extra column to the table for the search history (this session and previous searches) with RSS icons for each search. Test plan: * Verify that there is no RSS icons for saved searches in opac * Install the patch * Verify that there is no RSS icons for saved searches and searches for the current session in Opac. * Test that the RSS links produce the expected result. Note: I left out authority searches since I have very little experience with authority searches and didn't feel I could test it properly. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> All looks good. But one icon in a cell does not seem very elegant. Maybe Owen has a brainwave? I'd say just have the RSS icon to the left of the search terms without a header row. The icon is pretty clear on it's own. But I signed off cause it got the functionality in there and figured a follow up could make it pretty. (In reply to Nicole C. Engard from comment #6) > I'd say just have the RSS icon to the left of the search terms without a > header row. The icon is pretty clear on it's own. But I signed off cause it > got the functionality in there and figured a follow up could make it pretty. To the left of the search sounds good. It's an easy fix but what's the workflow for fixing that? Should I submit a new patch to this thread even though it's signed off? Or do I have to wait until the patch is pushed to master until I can pick it up and change it? (In reply to Viktor Sarge from comment #7) > To the left of the search sounds good. It's an easy fix but what's the > workflow for fixing that? Should I submit a new patch to this thread even > though it's signed off? Or do I have to wait until the patch is pushed to > master until I can pick it up and change it? You can submit a follow-up on this bug report and switch the status back to "Needs Signoff". > You can submit a follow-up on this bug report and switch the status back to
> "Needs Signoff".
Seems I have messed something up with my git. It won't add the file again since it thinks nothing is changed. Working on it since it RSS icons to the left of the search instead looks quite a bit better.
Created attachment 28983 [details] [review] Bug 5672 Gives RSS icons to search history placed to the left of saved searches Test plan: * Verify that there is no RSS icons for saved searches in opac * Install the patch * Verify that there is no RSS icons for saved searches and searches for the current session in Opac. * Test that the RSS links produce the expected result. Note: I left out authority searches since I have very little experience with authority searches and didn't feel I could test it properly. Created attachment 28984 [details] [review] 5672 Gives RSS icons to search history This patch adds an extra column to the table for the search history (this session and previous searches) with RSS icons for each search. Test plan: * Verify that there is no RSS icons for saved searches in opac * Install the patch * Verify that there is no RSS icons for saved searches and searches for the current session in Opac. * Test that the RSS links produce the expected result. Note: I left out authority searches since I have very little experience with authority searches and didn't feel I could test it properly. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Created attachment 28985 [details] [review] Bug 5672 Gives RSS icons to search history placed to the left of saved searches Test plan: * Verify that there is no RSS icons for saved searches in opac * Install the patch * Verify that there is no RSS icons for saved searches and searches for the current session in Opac. * Test that the RSS links produce the expected result. Note: I left out authority searches since I have very little experience with authority searches and didn't feel I could test it properly. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Created attachment 29010 [details] [review] Bug 5672 Gives RSS icons to catalog search history This patch adds an extra column to the table for the search history (this session and previous searches) with RSS icons for each search. Test plan: * Verify that there is no RSS icons for saved searches in opac * Install the patch * Verify that there is no RSS icons for saved searches and searches for the current session in Opac. * Test that the RSS links produce the expected result. Note: I left out authority searches since I have very little experience with authority searches and didn't feel I could test it properly. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Created attachment 29011 [details] [review] Bug 5672 Gives RSS icons to catalog search history placed to the left of saved searches Test plan: * Verify that there is no RSS icons for saved searches in opac * Install the patch * Verify that there is no RSS icons for saved searches and searches for the current session in Opac. * Test that the RSS links produce the expected result. Note: I left out authority searches since I have very little experience with authority searches and didn't feel I could test it properly. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> I updated bug report summary and commit message to highlight that the patches only affect catalog search history (not authority). Created attachment 29018 [details] [review] [SIGNED-OFF] Bug 5672 Gives RSS icons to catalog search history placed to the left of saved searches Test plan: * Verify that there is no RSS icons for saved searches in opac * Install the patch * Verify that there is no RSS icons for saved searches and searches for the current session in Opac. * Test that the RSS links produce the expected result. Note: I left out authority searches since I have very little experience with authority searches and didn't feel I could test it properly. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Sorry, I missed an update in my email and didn't check here - so I signed off after QA again :) Patches pushed to master. Thanks Viktor! |