Summary: | Intranet - Circulation - Fines : debug calculation when fines are reversed then re-payed | ||
---|---|---|---|
Product: | Koha | Reporter: | Brice Sanchez <brice.sanchez> |
Component: | Circulation | Assignee: | Brice Sanchez <brice.sanchez> |
Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
Severity: | major | ||
Priority: | PATCH-Sent (DO NOT USE) | CC: | chris, gmcharlt, mcoalwell, paul.poulain, wizzyrea |
Version: | 3.4 | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | Sponsored | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
patch for this bug
patch for this bug Signed off patch proposed patch (passed QA) |
Description
Brice Sanchez
2011-02-08 15:03:51 UTC
Created attachment 3092 [details] [review] patch for this bug I tried to apply this patch using git am and got this message: Applying: debug calculation when fines are reversed then re-payed fatal: corrupt patch at line 77 Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 debug calculation when fines are reversed then re-payed Created attachment 3098 [details] [review] patch for this bug try this patch, it should be good. Created attachment 4215 [details] [review] Signed off patch Created attachment 4841 [details] [review] proposed patch (passed QA) QA comment * the indentation was made with <TAB> => brice = please use 4 spaces, this is the common rule for Koha. I've fixed the problem, but next time, i'll mark "failed QA" * The patch was conflicting with 6305 (removal of 3 my $sth). Solving the conflict was easy, so I made it too * Same comment as Katrin: could not reproduce the calculation error, but confirm accountlines table is not filled and filled and filled by payements/revers/payement => marking passed QA Pushed please test Tested, works great thanks! |