Summary: | Add coins information to the intranet | ||
---|---|---|---|
Product: | Koha | Reporter: | Chris Cormack <chris> |
Component: | Staff interface | Assignee: | Paul Poulain <paul.poulain> |
Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
Severity: | enhancement | ||
Priority: | PATCH-Sent (DO NOT USE) | CC: | f.demians, gmcharlt, koha.sekjal, nengard |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Bug Depends on: | 5957, 7073 | ||
Bug Blocks: | |||
Attachments: |
Proposed Patch
proposed patch Bug 5729 - Add CoinS to intranet Bug 5729 - Add CoinS to intranet Rebased/Passed QA patch |
Description
Chris Cormack
2011-02-10 01:14:55 UTC
Created attachment 3117 [details] [review] Proposed Patch Chris, Does this mean that Zotero will work in the staff client? Is there anything else it can do? Just checking before I test to see what I'm looking for. Nicole Nicole, yes it makes coinS work on staff interface I dont think this patch applied. I didn't see any change in the staff client and I got this when I tried to apply the patch: Apply? [y]es/[n]o/[e]dit/[v]iew patch/[a]ccept all y Applying: Bug 5729 : Add Coins support to intranet Using index info to reconstruct a base tree... <stdin>:65: trailing whitespace. { # <stdin>:93: trailing whitespace. <!-- /TMPL_IF --> <stdin>:117: trailing whitespace. display: block; <stdin>:132: trailing whitespace. <!-- /TMPL_IF --> <stdin>:150: trailing whitespace. , entries/page : warning: squelched 3 whitespace errors warning: 8 lines add whitespace errors. Falling back to patching base and 3-way merge... Auto-merging catalogue/MARCdetail.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/MARCdetail.tmpl nengard@debian:~/kohaclone$ As long as git doesn't ask you to resolve a conflict and it doesn't tell you explicitly the patch failed then I think you can assume the patch was applied. Whether or not a patch does anything is another matter :) Okay then, I applied the patch and when I did a search I didn't see my usual Zotero icon in the address bar that indicates that CoinS is working. This bug is mentioned in: Bug 5729 : Add Coins support to intranet http://lists.koha-community.org/pipermail/koha-patches/2011-February/013811.html Created attachment 5379 [details] [review] proposed patch New patch, completly rewritten : * all code not related to Adding CoinS has been removed * T::T compliant How to test : * add zotero to your firefox * open a biblio in staff interface (default, marc or isbd view) => you should get the zotero icon in your firefox toolbar (if your biblio is correct of course. If you get it in OPAC, you must have it in staff to) (In reply to comment #8) > Created attachment 5379 [details] [review] > proposed patch > > New patch, completly rewritten : > * all code not related to Adding CoinS has been removed > * T::T compliant There is syspref COinSinOPACResults controling if COinS tag is displayed or not on OPAC search result page. This is a recent enhencement: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5957 This has been added for efficiency reason. Shouldn't we use a similar syspref for staff interface? or better: the function generating COinS could be improved... Created attachment 5610 [details] [review] Bug 5729 - Add CoinS to intranet This patch adds CoinS support to biblio displays in staff interface. librarians can now use zotero on the staff interface Adding dependence on 7073, which changes the parameters required by GetCOinSBiblio from biblionumber to GetMarcBiblio-sourced $record Updating Version : This ENH will be for Koha 3.8 Bug versionned for master. entries will be made against rel_3_8 once the patch has been applied (see thread about that on koha-devel yesterday) Created attachment 6796 [details] [review] Bug 5729 - Add CoinS to intranet This patch adds CoinS support to biblio displays in staff interface. librarians can now use zotero on the staff interface Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Created attachment 6914 [details] [review] Rebased/Passed QA patch Passed QA patch, with reflection of the new GetCOinSBiblio interface (uses $record now, not $biblionumber, for increased efficiency on most pages). patch pushed, please test |