| Summary: | link to acq from budgets & funds | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Nicole C. Engard <nengard> |
| Component: | Templates | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | aleisha, kyle, oleonard |
| Version: | Main | Keywords: | Academy |
| Hardware: | All | ||
| OS: | All | ||
| URL: | /cgi-bin/koha/admin/aqbudgets.pl | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17972 | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 17972 | ||
| Attachments: |
Bug 5784 - link to aq from budgets & funds
Bug 5784 - link to aq from budgets & funds Bug 5784 - link to aq from budgets & funds Bug 5784 [QA Followup] - Move link to breadcrumbs Bug 5784 - Undo link in breadcrumbs |
||
|
Description
Nicole C. Engard
2011-02-21 17:07:06 UTC
Created attachment 59113 [details] [review] Bug 5784 - link to aq from budgets & funds 1. Go to /cgi-bin/koha/admin/aqbudgets.pl and notice that there is no link to the aq home, there are other aq links but not back to the home 2. Apply the patch 3. Reload the page and notice there is link Created attachment 59143 [details] [review] Bug 5784 - link to aq from budgets & funds 1. Go to /cgi-bin/koha/admin/aqbudgets.pl and notice that there is no link to the aq home, there are other aq links but not back to the home 2. Apply the patch 3. Reload the page and notice there is link Signed-off-by: Claire Gravely <claire_gravely@hotmail.com> Created attachment 59234 [details] [review] Bug 5784 - link to aq from budgets & funds 1. Go to /cgi-bin/koha/admin/aqbudgets.pl and notice that there is no link to the aq home, there are other aq links but not back to the home 2. Apply the patch 3. Reload the page and notice there is link Signed-off-by: Claire Gravely <claire_gravely@hotmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 59235 [details] [review] Bug 5784 [QA Followup] - Move link to breadcrumbs Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Pushed to master for 17.05, thanks Grace! I am not sure about the follow-up - + <span><a href="/cgi-bin/koha/acqui/acqui-home.pl">Budgets administration</a></span> I wouldn't expect "Budgets administration" to lead to the acquisition start page - but to the budgets page. I think the follow-up is not correct. - The last bit of the breadcrumb is the page you are on - so that should not be linked to the acquisition home page. - It only appears on budgets, but not on funds, the original patch was in the include for all the pages. Also not on currencies. (In reply to Katrin Fischer from comment #7) > I think the follow-up is not correct. > > - The last bit of the breadcrumb is the page you are on - so that should not > be linked to the acquisition home page. > - It only appears on budgets, but not on funds, the original patch was in > the include for all the pages. Also not on currencies. Agreed. The problem is that the budget and fund links are technically administration sections, where the rest are actually acquisitions. This make the breadcrumb linked more complicated than it should be ; ) Katrin, would you recommend I simply revert the followup, or do you have another recommendation? Funds, budgets and currencies being in administration and not in acquisitions is a problem we run into every now and then - like with permissions or now the breadcrumbs. I have seen people get stuck there, so a link could indeed be helpful. I think the first patch would work for now, but we should fix capitalization in a follow-up :) Maybe we could divide the side navigation into 'Administration' and 'Acquisitions' sections to make it a little easier to understand the differences? Adding Owen in hope he has an idea. (In reply to Kyle M Hall from comment #8) > Katrin, would you recommend I simply revert the followup, or do you have > another recommendation? I would revert the followup. (In reply to Katrin Fischer from comment #9) > I think the first patch would work for now, > but we should fix capitalization in a follow-up :) I agree. > Maybe we could divide the side navigation into 'Administration' and > 'Acquisitions' sections to make it a little easier to understand the > differences? I'm going to submit a patch on a separate bug. Do we still need to revert, or just the new patch from 17972? Waiting for this to be resolved on master before pushing to 16.11.x Issue resolved by 17972. Pushing followup to remove link from breadcrumbs. Created attachment 60410 [details] [review] Bug 5784 - Undo link in breadcrumbs Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> This won't get ported back to 16.11.x as it is an enhancement. |