Bug 5787

Summary: Move OPACItemHolds system preference to the Circulation Matrix.
Product: Koha Reporter: Chris Cormack <chris>
Component: Hold requestsAssignee: Srdjan Jankovic <srdjan>
Status: RESOLVED DUPLICATE QA Contact: Bugs List <koha-bugs>
Severity: enhancement    
Priority: P5 - low CC: gmcharlt, julian.maurice, katrin.fischer, melia
Version: 3.4   
Hardware: All   
OS: All   
Change sponsored?: Sponsored Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 5786    
Bug Blocks: 5609    
Attachments: patch
patch

Description Chris Cormack 2011-02-21 20:01:32 UTC
Allowing it to be restricted by itemtype or patrontype, not a blanket preference
Comment 1 Srdjan Jankovic 2011-07-22 05:58:36 UTC Comment hidden (obsolete)
Comment 2 Srdjan Jankovic 2011-07-22 07:32:26 UTC Comment hidden (obsolete)
Comment 3 Paul Poulain 2012-02-17 14:39:05 UTC
The script devel/misc/testbugzillapatches.pl has detected that this bug does not apply anymore, so i'm marking this bug as "does not apply".

The script is supposed to handle conflicts related to updatedatabase, but no other cases of merge conflict. So the conflict may be trivial to fix.

If it happens that the patch attached does apply cleanly, please send me an email, there's something wrong in the script. It's possible, as it's a recent script.
If the patch applies does not apply as I think, please rebase and resubmit, thanks
Comment 4 Melia Meggs 2012-07-24 23:26:26 UTC
A new patch coming soon for this!!  I want to provide test plans to facilitate community testing.


Test plan for OPAC Item Holds only:


Rule 1:
Patron Category 1
Item type 1
Allow patrons to place item specific holds

Rule 2:
Patron Category 2
Item type 2
Don't Allow patrons to place item specific holds

In both the staff client and the OPAC try the following for each rule combo:

Place an item specific hold

--------------------

Please test with Bug 5786 as well.


Test Plan for both On Shelf Holds and OPAC Item Holds together


Set up the following rules:

Rule 1:
Patron Category 1
Item type 1
On Shelf Holds Not Allowed
Allow patrons to place item specific holds

Rule 2:
Patron Category 2
Item type 2
On Shelf Holds Allowed
Allow patrons to place item specific holds

Rule 3:
Patron Category 3
Item type 3
On Shelf Holds Allowed
Don't allow patrons to place item specific holds

Rule 4:
Patron Category 4
Item type 4
On Shelf Holds not Allowed
Don't allow patrons to place item specific holds


In both the staff client and the OPAC try the following for each rule combo:

Place hold on shelf item
Place hold on checked out item
Place an item specific hold
Comment 5 Srdjan Jankovic 2012-07-25 03:47:53 UTC
This bug will be resolved in unified patch on bug 5786
Comment 6 Srdjan Jankovic 2012-07-25 03:49:39 UTC
Comment on attachment 4712 [details] [review]
patch

Integrated with 5786 and 5788
Comment 7 Julian Maurice 2012-08-06 14:27:59 UTC
As it was merged with bug 5786, I think the appropriate status is RESOLVED - DUPLICATE

*** This bug has been marked as a duplicate of bug 5786 ***