Summary: | Don't show sql statement on guided reports result page | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | Reports | Assignee: | Katrin Fischer <katrin.fischer> |
Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
Severity: | enhancement | ||
Priority: | PATCH-Sent (DO NOT USE) | CC: | chris, jcamins, mark.gavillet, nengard, paul.poulain |
Version: | master | ||
Hardware: | All | ||
OS: | All | ||
URL: | /cgi-bin/koha/reports/guided_reports.pl?reports=1&phase=Run this report | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Attachments: |
proposed patch
screenshot New patch Signed-off patch |
Description
Katrin Fischer
2011-03-07 07:06:38 UTC
Created attachment 3258 [details] [review] proposed patch Not sure I agree with this idea. I find handfull to have the details of the report in case of printing it. (won't argue for hours if others say "yes it's a good idea" though) Hi Paul, I disagree :) I especially don't like it on printouts. My librarians have no idea about the sql behind the reporst and are more confused by it than that it is helpful for them. Also you might want to hang up some of your printed reports in the library. The sql output currently is not formatted in any way, not wrapped into a html tag even and flowing together with the pagination. Making the pagination hard to be seen. And longer sql statements quite unreadable. Can I have a link to a page that shows the way this used to appear? I'm confused about how to test this because I'm not sure what page to look at. Hi Nicole, thx for testing :) 1) Create a new report from sql 2) Run it 3) Look at the top of the results page URL will be something like '/cgi-bin/koha/reports/guided_reports.pl?reports=1&phase=Run this report'. Created attachment 3442 [details]
screenshot
New suggestion: wrapping the sql output in <pre> with unique id.
- sql can be formatted
- sql can be hidden using css and the unique id
- pagination is pushed to its own line and better visible
Created attachment 3443 [details] [review] New patch Created attachment 3445 [details] [review] Signed-off patch I like this new patch much better, pushed, please test This bug is mentioned in: Bug 5838: Don't show sql statement on guided reports result page http://lists.koha-community.org/pipermail/koha-patches/2011-March/013998.html Bug 5838: Don't show sql statement on guided reports result page http://lists.koha-community.org/pipermail/koha-patches/2011-March/014007.html Bug 5838: Format sql outout on guided reports http://lists.koha-community.org/pipermail/koha-patches/2011-March/014240.html Bug 5838: Format sql outout on guided reports http://lists.koha-community.org/pipermail/koha-patches/2011-March/014241.html |