Summary: | Same position for the tabs of Normal, MARC and ISBD view in opac detail | ||
---|---|---|---|
Product: | Koha | Reporter: | Marcel de Rooy <m.de.rooy> |
Component: | OPAC | Assignee: | Marcel de Rooy <m.de.rooy> |
Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
Severity: | enhancement | ||
Priority: | PATCH-Sent (DO NOT USE) | CC: | chris, julian.maurice |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Patch
normal view like it is now normal view after patch duplicated tabs Patch for Unimarc stylesheet |
Description
Marcel de Rooy
2011-03-10 13:06:10 UTC
Please test all three views 1) with OPACXSLTDetailsDisplay enabled [MARC View: Test also "View plain" here] 2) with OPACXSLTDetailsDisplay disabled. Created attachment 3280 [details] [review] Patch Created attachment 3286 [details]
normal view like it is now
Created attachment 3287 [details]
normal view after patch
Signing-off on this, it works like described. I like the new display, it seems more consistent and a bit cleaner to me. Not sure if this is the majority opinion though. Pushed, please test and mark resolved Works for me. Anyone else to close it? Created attachment 3292 [details]
duplicated tabs
On Normal view I see the tabs twice (see screenshot).
Marc/Plain/ISBD views display well.
I notice that the tabs are not the same. Are you using a custom xslt stylesheet? The stylesheet for MARC21 opac details was adjusted in the patch. Is it possible that these views are still in your Unimarc xslt file? Julian, I see that lines 55 up to 69 still contain the views in a div tag in the UNIMARCslim2OPACDetail.xsl in koha-tmpl/opac-tmpl/prog/en/xslt. Could you please test removing them? (In reply to comment #10) > Julian, > I see that lines 55 up to 69 still contain the views in a div tag in the > UNIMARCslim2OPACDetail.xsl in koha-tmpl/opac-tmpl/prog/en/xslt. > Could you please test removing them? That's it! Preparing a patch for Unimarc stylesheet... Created attachment 3321 [details] [review] Patch for Unimarc stylesheet Follow up patch for UNIMARC pushed, please test This bug is mentioned in: Bug 5848: Same position for the tabs of Normal, MARC and ISBD view in opac detail http://lists.koha-community.org/pipermail/koha-patches/2011-March/014035.html Bug 5848: Remove duplicated tabs in opac details for Unimarc http://lists.koha-community.org/pipermail/koha-patches/2011-March/014079.html Bug 5848: Remove duplicated tabs in opac details for Unimarc http://lists.koha-community.org/pipermail/koha-patches/2011-March/014100.html |