Bug 5867

Summary: "Hold filled" notice not sent by email if the user has its email address in a field other than "email"
Product: Koha Reporter: Frédérick Capovilla <fcapovilla>
Component: NoticesAssignee: Frédérick Capovilla <fcapovilla>
Status: CLOSED FIXED QA Contact: Bugs List <koha-bugs>
Severity: enhancement    
Priority: PATCH-Sent (DO NOT USE) CC: chris, koha.sekjal
Version: rel_3_2   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: --- Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
Circulation function:
Attachments: [PATCH] Improved the email checking when sending "Hold filled" notices.
Bug 5867 : Improved the email checking when sending "Hold filled" notices.

Description Frédérick Capovilla 2011-03-15 15:42:37 UTC Comment hidden (obsolete)
Comment 1 Chris Cormack 2011-05-30 10:42:19 UTC
Created attachment 4302 [details] [review]
Bug 5867 : Improved the email checking when sending "Hold filled" notices.

The subroutine for sending HOLD and HOLD_PRINT notices only checked the
"email" field of the borrowers table and didn't check the value of the
AutoEmailPrimaryAddress preference. With this patch, "Hold filled"
notices can now be sent using the other email addresses of the member.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5867
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Comment 2 Chris Cormack 2011-05-30 10:43:14 UTC
Signed off patch attached
Comment 3 Ian Walls 2011-07-14 22:41:15 UTC
Easy patch to read, uses existing subroutines correctly.  Marking as Passed QA
Comment 4 Chris Cormack 2011-07-14 23:11:35 UTC
Pushed, please test