Summary: | Enhancements to suggestions management | ||
---|---|---|---|
Product: | Koha | Reporter: | Chris Cormack <chris> |
Component: | Acquisitions | Assignee: | Paul Poulain <paul.poulain> |
Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
Severity: | enhancement | ||
Priority: | PATCH-Sent (DO NOT USE) | CC: | julian.maurice, nengard |
Version: | 3.4 | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 5580 | ||
Attachments: |
Proposed Patch
Followup patch |
Description
Chris Cormack
2011-03-15 23:52:44 UTC
* changing suggestedy management * adding a new status field & filter Created attachment 3308 [details] [review] Proposed Patch I'm getting a JS error on suggestion.pl: document.getElementById("quantity") is null /intranet-tmpl/prog/en/js/acq.js Line 686 Perhaps because I have no suggestions? Apply? [y]es/[n]o/[e]dit/[v]iew patch/[a]ccept all y Applying: Bug 5870 : suggestion management enhancements fatal: corrupt patch at line 138 Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 5870 : suggestion management enhancements When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". nengard@debian:~/kohaclone$ It applied fine for me. Did you pull from master this morning before applying? Not sure why it's not applying on mine - guess we need someone else to test. Nicole It applies fine for me too and it works well. Signed off. Julian, did you test the error Owen was getting. Id like this error investigated before I push it to master Attaching a follow up patch, * followup debug suggestion management : "accepted by" was not correctly displayed on suggestion's edit page * suggestion's status, document's type and "accepted by" was not correctly displayed on suggestion's edit page Created attachment 3450 [details] [review] Followup patch (In reply to comment #8) > Julian, did you test the error Owen was getting. Id like this error > investigated before I push it to master I didn't manage to reproduce the bug, even with no suggestions. So I can't tell you more about this. Pushed, please test This bug is mentioned in: Bug 5870 : suggestion management enhancements http://lists.koha-community.org/pipermail/koha-patches/2011-March/014063.html Bug 5870 : suggestion management enhancements http://lists.koha-community.org/pipermail/koha-patches/2011-March/014213.html Bug 5870 : Follow up clean up patch http://lists.koha-community.org/pipermail/koha-patches/2011-March/014247.html |