Bug 5874

Summary: Overdue report : Limit by date & add a new permission to restrict who can run the report
Product: Koha Reporter: Chris Cormack <chris>
Component: CirculationAssignee: Paul Poulain <paul.poulain>
Status: CLOSED DUPLICATE QA Contact: Bugs List <koha-bugs>
Severity: enhancement    
Priority: PATCH-Sent (DO NOT USE) CC: gmcharlt, julian.maurice, kyle.m.hall, melia, nengard
Version: 3.4   
Hardware: All   
OS: All   
See Also: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6898
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 5876    
Bug Blocks: 5575, 5877    
Attachments: Proposed Patch
Esthetic problem

Description Chris Cormack 2011-03-16 01:07:22 UTC
circ/overdue.pl modified : limit on date & new permission

- the Overdues.pl now is now available to ppl with reports->execute_reports permission
- there is a filter on date (to display only "old" or "new" overdues, for example)
Comment 1 Chris Cormack 2011-03-16 01:16:04 UTC
Created attachment 3312 [details] [review]
Proposed Patch
Comment 2 Julian Maurice 2011-03-16 15:30:51 UTC
Tested on master.
The filter works as expected, but it needs some esthetic improvement.
I will attach a screenshot.
Comment 3 Julian Maurice 2011-03-16 15:36:21 UTC
Created attachment 3324 [details]
Esthetic problem
Comment 4 Nicole C. Engard 2011-03-16 16:32:41 UTC
The patch works, but I'd like to see the dates not surrounded by a dotted line (a design issue) and I'd like the Overdue report link to be hidden if you don't have permissions to access it ... otherwise you click the overdues link and get an error saying you don't have permission.

Finally, if you have reports permissions and not circulation permissions you can't access the overdues report.
Comment 5 Nicole C. Engard 2011-03-16 16:33:53 UTC
Julian included a screenshot of the dotted line I was talking about.
Comment 6 Nicole C. Engard 2011-03-16 16:35:37 UTC
updating status - I don't see a signed off patch - and I think it's missing a couple of things to make it acceptable for pushing to master.
Comment 7 MJ Ray (software.coop) 2011-04-11 08:31:54 UTC
This bug is mentioned in:
Bug 5874 : circ/overdue.pl modified :	permission &amp; limit on date http://lists.koha-community.org/pipermail/koha-patches/2011-March/014069.html
Bug 5874 : circ/overdue.pl modified :	permission &amp; limit on date http://lists.koha-community.org/pipermail/koha-patches/2011-March/014088.html
Comment 8 Owen Leonard 2011-07-14 14:12:04 UTC
Hasn't this already been pushed? We've got the date due filter in place, and a follow-up patch was pushed addressing the design issue. The script has 'circulate_remaining_permissions.' As far as I can tell the only problem is that this may have introduced Bug 6585. Am I missing something?
Comment 9 Paul Poulain 2011-08-01 16:32:09 UTC
owen is right: patch already applied through 6049

*** This bug has been marked as a duplicate of bug 6049 ***
Comment 10 Nicole C. Engard 2011-09-21 12:22:54 UTC
Why is this marked resolved. Only one of the issues is resolved - the fact that you can't access overdues without reports permissions is still a problem.
Comment 11 Melia Meggs 2012-02-07 22:55:46 UTC
I am reopening this.

If a staff member has the execute_reports permission but does not have the other reports permissions, he is unable to run the overdues report.

Some staff need to be able to run the overdues report without being able to create reports.
Comment 12 Kyle M Hall 2012-02-10 15:51:49 UTC
(In reply to comment #11)

I has submitted a patch to fix this issue under bug 6898

> I am reopening this.
> 
> If a staff member has the execute_reports permission but does not have the
> other reports permissions, he is unable to run the overdues report.
> 
> Some staff need to be able to run the overdues report without being able to
> create reports.
Comment 13 Kyle M Hall 2012-02-10 15:54:01 UTC

*** This bug has been marked as a duplicate of bug 6898 ***