Summary: | Overdue report : Limit by date & add a new permission to restrict who can run the report | ||
---|---|---|---|
Product: | Koha | Reporter: | Chris Cormack <chris> |
Component: | Circulation | Assignee: | Paul Poulain <paul.poulain> |
Status: | CLOSED DUPLICATE | QA Contact: | Bugs List <koha-bugs> |
Severity: | enhancement | ||
Priority: | PATCH-Sent (DO NOT USE) | CC: | gmcharlt, julian.maurice, kyle.m.hall, melia, nengard |
Version: | 3.4 | ||
Hardware: | All | ||
OS: | All | ||
See Also: | http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6898 | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 5876 | ||
Bug Blocks: | 5575, 5877 | ||
Attachments: |
Proposed Patch
Esthetic problem |
Description
Chris Cormack
2011-03-16 01:07:22 UTC
Created attachment 3312 [details] [review] Proposed Patch Tested on master. The filter works as expected, but it needs some esthetic improvement. I will attach a screenshot. Created attachment 3324 [details]
Esthetic problem
The patch works, but I'd like to see the dates not surrounded by a dotted line (a design issue) and I'd like the Overdue report link to be hidden if you don't have permissions to access it ... otherwise you click the overdues link and get an error saying you don't have permission. Finally, if you have reports permissions and not circulation permissions you can't access the overdues report. Julian included a screenshot of the dotted line I was talking about. updating status - I don't see a signed off patch - and I think it's missing a couple of things to make it acceptable for pushing to master. This bug is mentioned in: Bug 5874 : circ/overdue.pl modified : permission & limit on date http://lists.koha-community.org/pipermail/koha-patches/2011-March/014069.html Bug 5874 : circ/overdue.pl modified : permission & limit on date http://lists.koha-community.org/pipermail/koha-patches/2011-March/014088.html Hasn't this already been pushed? We've got the date due filter in place, and a follow-up patch was pushed addressing the design issue. The script has 'circulate_remaining_permissions.' As far as I can tell the only problem is that this may have introduced Bug 6585. Am I missing something? owen is right: patch already applied through 6049 *** This bug has been marked as a duplicate of bug 6049 *** Why is this marked resolved. Only one of the issues is resolved - the fact that you can't access overdues without reports permissions is still a problem. I am reopening this. If a staff member has the execute_reports permission but does not have the other reports permissions, he is unable to run the overdues report. Some staff need to be able to run the overdues report without being able to create reports. (In reply to comment #11) I has submitted a patch to fix this issue under bug 6898 > I am reopening this. > > If a staff member has the execute_reports permission but does not have the > other reports permissions, he is unable to run the overdues report. > > Some staff need to be able to run the overdues report without being able to > create reports. *** This bug has been marked as a duplicate of bug 6898 *** |