As described on the wiki :
These are in new/awaiting_qa/enh/bug_5575
=> missing field in database
[Tue Jan 11 10:49:56 2011] [error] [client 220.127.116.11] [Tue Jan 11 10:49:56 2011] maninvoice.pl: DBD::mysql::st execute failed: Unknown column 'time' in 'field list' at /home/koha/versions/3.4/borrowers/C4/Accounts.pm line 446., referer: http://borrowers34.git.biblibre.com/cgi-bin/koha/members/maninvoice.pl?borrowernumber=51
=> BibLlibre mistake : the new fields are in updatedatabase, but not in kohastructure.sql (also in our master branch)
ok, part payement fixed, with some other merge problems.
6a0f4c672461f2a1dc242b51933978e5329ca845 and 088dbd23a1681fcdcc031aab5b2bcfabb6108899
index = id.IndexOf("_");
On moremember.pl under the "Suggestions" tab, authorized values for reasonACCEPTED are not appearing.
On moremember.pl under the checkouts tab, barcode has been moved back into its own column. Is this intentional?
There is now a "Stock number" column, but with my data that column is empty. What is it for?
This display has diverged again from the one on circulation.pl, reopening Bug 3106.
On members/boraccount.pl under the "Account" tab, "action" columns like "print" and "reverse" should be excluded from the js tablesorter.
/tools/viewlog.pl would benefit from the addition of the tablesorter pager plugin.
With XSLTDetailsDisplay, I get an error from catalogue/detail.pl: Can't call method "subfield" on an undefined value at /C4/XSLT.pm line 127.
Clicking "Batch edit" from the staff client Cart results in a 404 error ("/cgi-bin/koha/tools/batchedit.pl?bib_list=XXX/XXX").
On the circulation page, clicking the "Override renewal limit" checkbox doesn't display the renew checkboxes. Only after clicking it again (unchecking it) do the renew checkboxes appear.
How new was the version of Koha these changes were built on? The circulation page shows a bug that was fixed in December 2010. Bug 5281
(In reply to comment #12)
> How new was the version of Koha these changes were built on? The circulation
> page shows a bug that was fixed in December 2010. Bug 5281
I've rebased on dec, 14th. seems the patch should still be valid. Will double check & fix if needed
comment 4: fixed in ceb470dcebcadeb32e458448211d4ecebaa3c8e4
comment 5: fixed in 9b8e63aa79abec5d6626243f46aebd35dfeb4dd9
comment 6: the stocknumber is the inventory number. it differs from the barcode as it's a "forever" number, the barcode can be changed. It's a legal requirement in France to have such a number for each book you buy. it has been added a while ago by us. Don't you use such an identifier in US ? About the "reordering" of the table, it was not intentional. Should be fixed.
comment 7 and 8: you're probably right, but it is en enhancement and should be in another bz entry
comment 9: fixed in 51e42cf14351c5a30d6b29ad9d998b3c1f9a136c Behaviour improved = XSLT are no more a boolean, but a full xslt path (with or without http) some things were lost in merging + updating sysprefs
comment 10: batchedit is in another branch. I suggest to let the link as is, it will work when BibLibre-cataloguing will be merged too.
comment 11: fixed in acf1cabd5ed3408e525a3958755ade545cb608e0
comment 12: fixed in a98f3f557acec7f11b15554509138f9e26bc682e
comment 13: can't reproduce the problem
On moremember.pl when I switch to the suggestions tab I see a table of suggestions and then below that I see a big block of jumbled text, as if the suggestions data were being redisplayed without the table markup. It looks to me like there is a problem with nesting <!-- TMPL_LOOP Name="suggestions" --> inside <!-- TMPL_LOOP NAME="suggestions_loop" -->
Created attachment 3011 [details] [review]
- Putting attributes and identifiers table inside TMPL_IF to avoid js error
- Correcting sorting columns
- Removing duplicate IDs
- Styling error message with standard <div class="dialog alert">
- Other minor markup corrections
/cgi-bin/koha/members/pay.pl: Selecting an option in the first column results in a JS error in: payfinechange(this.value,). Neither <!-- TMPL_VAR name="i" --> or <!-- TMPL_VAR name="accountlineid" --> are reaching the template.
How is the "means of payment" option populated?
Created attachment 3012 [details] [review]
Corrections for boraccount.tmpl
Correcting table sort columns, fixing markup
Created attachment 3013 [details] [review]
Restoring "float left" on fieldset.rows label. Removing it breaks the layout of all entry forms. Was it removed because it conflicted with another CSS change?
When using the patron duplicate function "initials" and "other name" are copied. I would think these, like first name, should be omitted from the fields copied.
Comment 4: Confirmed fixed.
Comment 5: Confirmed fixed.
Comment 7: Fixed.
Comment 9: No error now, but layout is broken. I will investigate.
Comment 11: Confirmed fixed.
Comment 13: Fixed.
I can see the guarantee's checkouts showing on the guarantor's checkout page, but why are the guarantor's checkouts showing on the guarantee's page?
Created attachment 3037 [details] [review]
Moving guarantee checkouts to tab; Markup corrections
Created attachment 3039 [details] [review]
XSLT details layout correction
The XSLTDetails template variable was changed, but only one of
three instances of that variable were updated in the template,
causing a broken layout (mentioned in comment 23).
Checking in an item gives me this error:
Can't call method "any" without a package or object reference at /home/oleonard/kohaclone/circ/returns.pl line 225.
I notice this branch includes the feature in circulation and fines rules which breaks the rules into tabs. It seems to be working, but the "filter" field at the top of the table doesn't.
JS Error: $.uiTableFilter is not a function
Paul : It should load uitablefilter.
The OPACPickupLocation preference is not being found by a system preference search and appears on the "Local Use" tab instead of the OPAC tab.
OPAC detail page layout problem: http://screencast.com/t/9zXqFhIoUqkp
Is this feature documented somewhere?
Created attachment 3041 [details]
I find the revised XSLT preferences to be quite confusing. One option is controlling both *whether* XSLT is on and *where* the stylesheet is located. With the new system preferences editor those two things don't work well together. I would suggest one preference for XSLT on or off and another for where the stylesheet is.
In the meantime the upgrade process needs to handle these values properly. My "on" and "off" preferences were kept as 0 and 1 rather than being translated to "(empty)" and "(correct XSL path)"
The checkouts tab on the circulation page now has a column "Material," which in my installation is empty. What is this intended to display? It seems to have replaced the "Price" column which is now absent. I no longer see "Stock number" on moremember.pl (see comment 6). Was it removed?
This bug is mentioned in:
Request to pull for bug 5575 http://lists.koha-community.org/pipermail/koha-patches/2011-January/013507.html
Bug 5575 Markup corrections: http://lists.koha-community.org/pipermail/koha-patches/2011-January/013684.html
I'm working on breaking this down into smaller bugs, ala 5574
I will build a dependency tree and hopefully we can get the bits signed off and merged.
Please hold off testing against this whole branch, instead when the patches for the individual bugs come through please test them instead.
Marking RESOLVED-WONTFIX, per IRC conversation with hdl.