| Summary: | waitingreserves highlighting now depends on maxpickupdate | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Chris Cormack <chris> |
| Component: | Circulation | Assignee: | Paul Poulain <paul.poulain> |
| Status: | CLOSED WONTFIX | QA Contact: | Bugs List <koha-bugs> |
| Severity: | enhancement | ||
| Priority: | P1 - high | CC: | gmcharlt, jcamins, julian.maurice |
| Version: | 3.4 | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 5872 | ||
| Bug Blocks: | |||
| Attachments: | Proposed Patch | ||
|
Description
Chris Cormack
2011-03-16 01:52:22 UTC
Created attachment 3313 [details] [review] Proposed Patch Why the created file reserves_waiting.inc is not included in any template? As is, it is useless. This bug is mentioned in: Bug 5875 : waitingreserves highlighting now depends on maxpickupdate http://lists.koha-community.org/pipermail/koha-patches/2011-March/014070.html Owen, can you explain where QA fails ? (In reply to comment #4) > Owen, can you explain where QA fails ? For the same reason Julian comments: The patch includes a file which isn't used. This patch depends on 5872. It uses the sub &GetMaxPickupDate from granular hold rules to calculate when a waiting reserve has to be cancelled. Once the 5872 has been applied, this one can be rewritten (removing the .inc that is useless) and tested again removing "patch sent" status, this patch will have to be rewritten * unclear description of the feature * missing file * HTML::Template and not Template::Toolkit thing * no Mantis number I could refer to well, marking "wontfix", I don't remember exactly what it was for (& i'm supposed to have written it ! |