| Summary: | Hide name of reviewer / comment writer in OPAC | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
| Component: | OPAC | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
| Severity: | enhancement | ||
| Priority: | PATCH-Sent (DO NOT USE) | CC: | chris, mark.gavillet, nengard |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Patch adding new syspref ShowReviewer
Follow-up fix for recent comments page |
||
|
Description
Katrin Fischer
2011-03-18 21:53:55 UTC
Created attachment 3441 [details] [review] Patch adding new syspref ShowReviewer This patch adds a new syspref ShowReviewer. If ON (default) the reviewer/author of an OPAC comment will show. If OFF the reviewer's name will be hidden. Apply? [y]es/[n]o/[e]dit/[v]iew patch/[a]ccept all y Applying: Bug 5897: Add new syspref ShowReviewer Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging installer/data/mysql/de-DE/mandatory/sysprefs.sql Auto-merging installer/data/mysql/en/mandatory/sysprefs.sql Auto-merging installer/data/mysql/fr-FR/1-Obligatoire/unimarc_standard_systemprefs.sql Auto-merging installer/data/mysql/it-IT/necessari/sysprefs.sql Auto-merging installer/data/mysql/pl-PL/mandatory/sysprefs.sql Auto-merging installer/data/mysql/ru-RU/mandatory/system_preferences_full_optimal_for_install_only.sql Auto-merging installer/data/mysql/uk-UA/mandatory/system_preferences_full_optimal_for_install_only.sql Auto-merging installer/data/mysql/updatedatabase.pl Auto-merging kohaversion.pl CONFLICT (content): Merge conflict in kohaversion.pl Failed to merge in the changes. Patch failed at 0001 Bug 5897: Add new syspref ShowReviewer When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". nengard@debian:~/kohaclone$ Signed off after editing kohaversion (where the conflict was) Pushed, please test Should I submit this as another enhancement? I'd like to see this preference expanded to also let people choose to show just the first name or just the username in addition to the full name or nothing at all. Other than that request it works. This bug is mentioned in: Bug 5897: Add new syspref ShowReviewer http://lists.koha-community.org/pipermail/koha-patches/2011-March/014269.html Bug 5897: Add new syspref ShowReviewer http://lists.koha-community.org/pipermail/koha-patches/2011-March/014238.html opac-showreviews.tt needs this change as well. Created attachment 3951 [details] [review] Follow-up fix for recent comments page Owen, I tested the follow up patch but no matter what i change 'showreviewer' to the name still shows. I am not logged in to the opac when this is happening and it's FF4 and Chrome that I have tested. Okay this is what I get for working too late ... I created a branch for the patch, but didn't apply the patch :) testing again. Pushed, please test *** Bug 5503 has been marked as a duplicate of this bug. *** There have been no further reports of problems so I am marking this bug resolved. |