Summary: | The search button is duplicated on advanced search | ||
---|---|---|---|
Product: | Koha | Reporter: | Chris Cormack <chris> |
Component: | OPAC | Assignee: | Paul Poulain <paul.poulain> |
Status: | CLOSED WONTFIX | QA Contact: | Bugs List <koha-bugs> |
Severity: | minor | ||
Priority: | PATCH-Sent (DO NOT USE) | CC: | jwagner, magnus, nengard |
Version: | 3.4 | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 5584 | ||
Attachments: | Proposed Patch |
Description
Chris Cormack
2011-03-28 20:13:20 UTC
Created attachment 3477 [details] [review] Proposed Patch Not sure what this means, but there are multiple search buttons on the advanced search page on purpose - it was an added feature a few releases ago to make it easier if people just want to use one part of the advanced search and not scroll all the way down. On reading the patch I see that it is removing the feature - I don't think this patch should be signed off on - but if it's a problem for some libraries it needs a preference to control. The duplicate button is a feature, not a bug. If libraries need to be able to hide it I suggest we make sure the markup allows it to be hidden with CSS. Yes, I added the extra search button at the top in Bug 3663 at the request of several of my sites. If there are a lot of item types in the system, a user might have to scroll down a long ways to find the original search button, and we got a lot of complaints about it. I would hope that this feature stays. i'm strongly against a syspref. But i'm OK for a css property. And I agree we can discard this patch. The problem is that library X want "white" and library Y want "black". Plus library Z prefers green... Sometimes, we must say "hey, it's OpenSource, but we should concentrate on important things..." |