| Summary: | Problem with changing quantity on uncertain prices list | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
| Component: | Acquisitions | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
| Severity: | major | ||
| Priority: | P5 - low | CC: | chris, jonathan.druart, tomascohen |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| URL: | /cgi-bin/koha/acqui/uncertainprice.pl?booksellerid=2&owner=1 | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 6059: Don't permit to change the quantity when items are created on ordering
Bug 6059: Don't permit to change the quantity when items are created on ordering [PASSED QA] Bug 6059: Don't permit to change the quantity when items are created on ordering |
||
|
Description
Katrin Fischer
2011-04-05 12:10:21 UTC
This appears to still be valid in master as of 3.12 beta1. Not sure to know what is the expected behavior here. Hi Jonathan, I think it should not be possible to edit the quantity when items are created 'on order' - because it won't create the items. Created attachment 37560 [details] [review] Bug 6059: Don't permit to change the quantity when items are created on ordering If items are created on ordering, the quantity for uncertain prices should not be editable. Test plan: 0/ Set AcqCreateItem to "on ordering" 1/ Create a basket and add an order with 1+ items 2/ Mark it as uncertain prices 3/ Go on the uncertain prices page for this vendor (acqui/uncertainprice.pl?booksellerid=X) 4/ Confirm you are not allowed to update the quantity 5/ Change the price and save 6/ Confirm the quantity is still correct Set the pref to another value and confirm the behavior has not changed. Created attachment 38149 [details] [review] Bug 6059: Don't permit to change the quantity when items are created on ordering If items are created on ordering, the quantity for uncertain prices should not be editable. Test plan: 0/ Set AcqCreateItem to "on ordering" 1/ Create a basket and add an order with 1+ items 2/ Mark it as uncertain prices 3/ Go on the uncertain prices page for this vendor (acqui/uncertainprice.pl?booksellerid=X) 4/ Confirm you are not allowed to update the quantity 5/ Change the price and save 6/ Confirm the quantity is still correct Set the pref to another value and confirm the behavior has not changed. NOTE: Tested with 'on placing order' and 'on receiving order'. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Created attachment 38153 [details] [review] [PASSED QA] Bug 6059: Don't permit to change the quantity when items are created on ordering If items are created on ordering, the quantity for uncertain prices should not be editable. Test plan: 0/ Set AcqCreateItem to "on ordering" 1/ Create a basket and add an order with 1+ items 2/ Mark it as uncertain prices 3/ Go on the uncertain prices page for this vendor (acqui/uncertainprice.pl?booksellerid=X) 4/ Confirm you are not allowed to update the quantity 5/ Change the price and save 6/ Confirm the quantity is still correct Set the pref to another value and confirm the behavior has not changed. NOTE: Tested with 'on placing order' and 'on receiving order'. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Patch pushed to master. Thanks Jonathan! Pushed to 3.18.x will be in 3.18.7 |