Summary: | string missing for translation in acq.js | ||
---|---|---|---|
Product: | Koha | Reporter: | Paul Poulain <paul.poulain> |
Component: | Acquisitions | Assignee: | Paul Poulain <paul.poulain> |
Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
Severity: | minor | ||
Priority: | PATCH-Sent (DO NOT USE) | CC: | chris, f.demians |
Version: | 3.4 | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 4503 | ||
Bug Blocks: | |||
Attachments: | proposed patch |
Description
Paul Poulain
2011-04-05 16:02:40 UTC
Created attachment 3713 [details] [review] proposed patch Linked script files are not processed by the translation script are they? Added connection to bug 4503: Javascript files in js directory are not translated Does the sign-off mean that js files can now be translated using po files and Pootle? (In reply to comment #4) > Does the sign-off mean that js files can now be translated using po files and > Pootle? Katrin, it's a minor patch. It allow two (2) strings to be translatable. Now those strings have to be extracted from .js file with a global strings update: translate update. I hasn't be done yet, since this patch isn't yet push, and so Pootle has not been updated. Sorry Frederic, I think there is a misunderstanding. I had filed bug 4503 a while back because the js files from the js directories were not going into po files for translation at all. I was asking if that happes now so that we can have strings for translations in the files. Some problems with those files have been solved by moving strings into the template files for translation. Katrin, it's my turn to be sorry. Bug 4503 is still here and so the patch for the above bug (#6073) will be useless. Strings from acq.js won't be extracted and put in .po file. It wouldn't hurt to put this patch, and, who knows, we can fix bug 4503 in a not too distant future... frederic++ = this patch can be applied. It will do nothing until the 4503 has been fixed, but it does not depend on 4503. (ps: should I say "i'm sorry" too ? :D :D) QA comment Very small patch, about strings. The result won't be visible until 4503 is fixed, but this one will have to be applied anyway. I mark it "passed QA" for those reasons, chris object or merge, thx Pushed, please test Can not be tested but does not seem to break anything. |