Bug 6073 - string missing for translation in acq.js
Summary: string missing for translation in acq.js
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: 3.4
Hardware: All All
: PATCH-Sent (DO NOT USE) minor (vote)
Assignee: Paul Poulain
QA Contact: Bugs List
URL:
Keywords:
Depends on: 4503
Blocks:
  Show dependency treegraph
 
Reported: 2011-04-05 16:02 UTC by Paul Poulain
Modified: 2012-10-25 23:09 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
proposed patch (1.29 KB, patch)
2011-04-05 16:04 UTC, Paul Poulain
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Poulain 2011-04-05 16:02:40 UTC
there's strings that misses the _() for translation in acq.js
Comment 1 Paul Poulain 2011-04-05 16:04:02 UTC
Created attachment 3713 [details] [review]
proposed patch
Comment 2 Owen Leonard 2011-04-05 16:10:04 UTC
Linked script files are not processed by the translation script are they?
Comment 3 Katrin Fischer 2011-04-05 16:14:41 UTC
Added connection to bug 4503: Javascript files in js directory are not translated
Comment 4 Katrin Fischer 2011-05-13 17:46:55 UTC
Does the sign-off mean that js files can now be translated using po files and Pootle?
Comment 5 Frédéric Demians 2011-05-13 17:53:39 UTC
(In reply to comment #4)
> Does the sign-off mean that js files can now be translated using po files and
> Pootle?

Katrin, it's a minor patch. It allow two (2) strings to be translatable. Now those strings have to be extracted from .js file with a global strings update: translate update. I hasn't be done yet, since this patch isn't yet push, and so Pootle has not been updated.
Comment 6 Katrin Fischer 2011-05-13 18:26:45 UTC
Sorry Frederic, I think there is a misunderstanding. I had filed bug 4503 a while back because the js files from the js directories were not going into po files for translation at all. I was asking if that happes now so that we can have strings for translations in the files. Some problems with those files have been solved by moving strings into the template files for translation.
Comment 7 Frédéric Demians 2011-05-13 19:26:01 UTC
Katrin, it's my turn to be sorry. Bug 4503 is still here and so the
patch for the above bug (#6073) will be useless. Strings from acq.js
won't be extracted and put in .po file. It wouldn't hurt to put this
patch, and, who knows, we can fix bug 4503 in a not too distant
future...
Comment 8 Paul Poulain 2011-05-16 08:24:09 UTC
frederic++ = this patch can be applied. It will do nothing until the 4503 has been fixed, but it does not depend on 4503.
(ps: should I say "i'm sorry" too ? :D :D)
Comment 9 Paul Poulain 2011-08-09 16:17:23 UTC
QA comment

Very small patch, about strings. The result won't be visible until 4503 is fixed, but this one will have to be applied anyway.
I mark it "passed QA" for those reasons, chris object or merge, thx
Comment 10 Chris Cormack 2011-08-10 01:18:34 UTC
Pushed, please test
Comment 11 Katrin Fischer 2011-10-26 18:57:08 UTC
Can not be tested but does not seem to break anything.