| Summary: | acqui pdf error when marcxml wrong | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Paul Poulain <paul.poulain> |
| Component: | Acquisitions | Assignee: | Paul Poulain <paul.poulain> |
| Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
| Severity: | normal | ||
| Priority: | PATCH-Sent (DO NOT USE) | CC: | chris, christophe.croullebois, koha.sekjal |
| Version: | 3.4 | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
proposed patch
Proposed patch |
||
|
Description
Paul Poulain
2011-04-05 21:08:02 UTC
Created attachment 3718 [details] [review] proposed patch How can this be tested? Created attachment 4593 [details] [review] Proposed patch Previous patch does not apply (fatal: sha1 information is lacking or useless (acqui/basketgroup.pl). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge.). This new patch is the same one but it apply. For test : edit marcxml directly in your database (ex. Delete </record>) and create a basketgroup with this notice. Before apply : Error 500 After : pdf is generated Code is straightforward change; separates the eval from the MARC::Record operations, allowing for failures to occur more gracefully. Marking as Passed QA Pushed please test There have been no further reports of problems so I am marking this bug resolved. |