when marcxml is wrong the PDF is not generated. There is a Perl error because the biblio can't be retrieved.
This can be workarounded with a eval when decoding the XML
Created attachment 3718 [details] [review]
How can this be tested?
Created attachment 4593 [details] [review]
Previous patch does not apply (fatal: sha1 information is lacking or useless (acqui/basketgroup.pl).
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.).
This new patch is the same one but it apply.
For test : edit marcxml directly in your database (ex. Delete </record>) and create a basketgroup with this notice.
Before apply : Error 500
After : pdf is generated
I have tested as said in comment 3, ok.
Code is straightforward change; separates the eval from the MARC::Record operations, allowing for failures to occur more gracefully. Marking as Passed QA
Pushed please test
There have been no further reports of problems so I am marking this bug resolved.