| Summary: | overdue_notices: when no notice, debarred action not done | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Julian Maurice <julian.maurice> |
| Component: | Command-line Utilities | Assignee: | Julian Maurice <julian.maurice> |
| Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
| Severity: | normal | ||
| Priority: | PATCH-Sent (DO NOT USE) | CC: | chris, koha.sekjal, mathilde.formery, paul.poulain |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 6328 | ||
| Bug Blocks: | |||
| Attachments: |
Patch
patch signed-off Bug 6097: overdue_notices.pl: when 'no notice' debarred action not done |
||
|
Description
Julian Maurice
2011-04-06 15:11:44 UTC
Created attachment 3754 [details] [review] Patch Created attachment 4065 [details] [review] patch signed-off This patch applies and work as expected (tested on a fresh install) EXCEPT = the call to C4::Member::DebarMember uses the API dealing with fine in days, that is still not in master. It works, throw no error, but the API is a future one. If this patch is pushed, it's wise to have the patch with the new API pushed at the same time ! However, I can't find those patches anywhere on bugzilla. The API change of C4::Members::DebarMember is part of the patches for the 'Fine in days' feature that is waiting for QA. (Bug 6328) This patch depends on 6328, which is currently Failed QA. Marking this as Failed QA to match, until it's pre-requisite is fixed. Created attachment 8086 [details] [review] Bug 6097: overdue_notices.pl: when 'no notice' debarred action not done When 'No notice' in overduerules, if action is debarr then the member would not be debarred. This patch fixes that. Bug 6328 is pushed to master, so I recreated the patch. It's not stricly the same that the signed-off one, so I removed the sign-off. error with sandbox Applying: Bug 6097: overdue_notices.pl: when 'no notice' debarred action not done Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging misc/cronjobs/overdue_notices.pl CONFLICT (content): Merge conflict in misc/cronjobs/overdue_notices.pl Failed to merge in the changes. Patch failed at 0001 Bug 6097: overdue_notices.pl: when 'no notice' debarred action not done Hi Julian, I tried fixing the conflict but failed. Can you please fix and resubmit? Thx! It seems that this has been fixed by bug 7001 (a9ded4fa008668df8c485fbbc76efa3cc9cc00d7). Can someone confirm this and close this bug? (Setting bug status to 'In Discussion') Closing this bug, it has been fixed by bug 7001 |