Bug 6097 - overdue_notices: when no notice, debarred action not done
Summary: overdue_notices: when no notice, debarred action not done
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Command-line Utilities (show other bugs)
Version: Main
Hardware: All All
: PATCH-Sent (DO NOT USE) normal
Assignee: Julian Maurice
QA Contact: Bugs List
URL:
Keywords:
Depends on: 6328
Blocks:
  Show dependency tree / graph
 
Reported: 2011-04-06 15:11 UTC by Julian Maurice
Modified: 2013-12-05 19:53 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Patch (2.84 KB, patch)
2011-04-06 15:17 UTC, Julian Maurice 		Details | Diff | Splinter Review
patch signed-off (2.90 KB, patch)
2011-05-09 16:18 UTC, Paul Poulain 		Details | Diff | Splinter Review
Bug 6097: overdue_notices.pl: when 'no notice' debarred action not done (2.22 KB, patch)
2012-03-08 13:44 UTC, Julian Maurice 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Julian Maurice 2011-04-06 15:11:44 UTC 
In overdue rules, when letter is set to "No notice", and debar is checked, the borrower would not be debarred.
Comment 1 Julian Maurice 2011-04-06 15:17:37 UTC Comment hidden (obsolete)
Comment 2 Paul Poulain 2011-05-09 16:18:17 UTC Comment hidden (obsolete)
Comment 3 Paul Poulain 2011-05-09 16:26:33 UTC 
This patch applies and work as expected (tested on a fresh install)

EXCEPT = the call to C4::Member::DebarMember uses the API dealing with fine in days, that is still not in master.
It works, throw no error, but the API is a future one. If this patch is pushed, it's wise to have the patch with the new API pushed at the same time ! However, I can't find those patches anywhere on bugzilla.
Comment 4 Katrin Fischer 2011-07-17 15:41:00 UTC 
The API change of C4::Members::DebarMember is part of the patches for the 'Fine in days' feature that is waiting for QA. (Bug 6328)
Comment 5 Ian Walls 2011-10-19 17:18:20 UTC 
This patch depends on 6328, which is currently Failed QA.  Marking this as Failed QA to match, until it's pre-requisite is fixed.
Comment 6 Julian Maurice 2012-03-08 13:44:47 UTC 
Created attachment 8086 [details] [review]
Bug 6097: overdue_notices.pl: when 'no notice' debarred action not done

When 'No notice' in overduerules, if action is debarr then the member
would not be debarred.
This patch fixes that.
Comment 7 Julian Maurice 2012-03-08 13:45:58 UTC 
Bug 6328 is pushed to master, so I recreated the patch.
It's not stricly the same that the signed-off one, so I removed the sign-off.
Comment 8 MathildeF 2012-03-20 09:33:14 UTC 
error with sandbox

Applying: Bug 6097: overdue_notices.pl: when 'no notice' debarred action not done
Using index info to reconstruct a base tree...
Falling back to patching base and 3-way merge...
Auto-merging misc/cronjobs/overdue_notices.pl
CONFLICT (content): Merge conflict in misc/cronjobs/overdue_notices.pl
Failed to merge in the changes.
Patch failed at 0001 Bug 6097: overdue_notices.pl: when 'no notice' debarred action not done
Comment 9 Katrin Fischer 2012-04-01 18:41:03 UTC 
Hi Julian,
I tried fixing the conflict but failed. Can you please fix and resubmit? Thx!
Comment 10 Julian Maurice 2012-04-18 13:23:08 UTC 
It seems that this has been fixed by bug 7001 (a9ded4fa008668df8c485fbbc76efa3cc9cc00d7).

Can someone confirm this and close this bug?
(Setting bug status to 'In Discussion')
Comment 11 Julian Maurice 2012-07-06 08:41:08 UTC 
Closing this bug, it has been fixed by bug 7001