Bug 6104

Summary:	Modifying an item causes it to lose its branch
Product:	Koha	Reporter:	Paul Poulain <paul.poulain>
Component:	Cataloging	Assignee:	Paul Poulain <paul.poulain>
Status:	CLOSED FIXED	QA Contact:	Bugs List <koha-bugs>
Severity:	critical
Priority:	PATCH-Sent (DO NOT USE)	CC:	chris, koha.sekjal, sophie.meynieux
Version:	3.4
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	---
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:
Circulation function:
Attachments:	proposed patch

Description Paul Poulain 2011-04-07 08:33:26 UTC

Under certain circumstances, the item branch, when modified is lost.

Step to reproduce:
* IndependantBranches=OFF
* have 2 branches
* connect as a librarian in branch A
* try to modify an item from branch B
=> the form now select branch A for the item

Comment 1 Paul Poulain 2011-04-07 08:34:56 UTC

Created attachment 3768 [details] [review]
proposed patch

Comment 2 Sophie MEYNIEUX 2011-04-07 09:24:08 UTC

I have tried to modify a item before applying the patch. Homebranch and holdingbranch are set to my branch whatever value they had before.

I have applied the patch and tried to modify an item. Homebranch and holding branch keep their previous value.

Comment 3 Chris Cormack 2011-04-07 22:30:48 UTC

Patch has not hit the mailing list yet, can it be attached to the bug.

Comment 4 Chris Cormack 2011-04-11 21:53:37 UTC

This still needs the signed off patch, I really would like to push this, but no signed off patch attached here, or on the mailing list

Comment 5 Chris Cormack 2011-04-14 06:31:17 UTC

Patch finally came through on the mailing list (i suspect it got held up for moderation) pushed now

Comment 6 Katrin Fischer 2011-04-24 12:00:11 UTC

Successfully tested on 3.4.