Bug 6179

Summary: Extra column on fines in staff client
Product: Koha Reporter: Nicole C. Engard <nengard>
Component: TemplatesAssignee: Owen Leonard <oleonard>
Status: CLOSED FIXED QA Contact: Bugs List <koha-bugs>
Severity: normal    
Priority: PATCH-Sent (DO NOT USE) CC: chris, magnus
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on:    
Bug Blocks: 5917    
Attachments: fines in staff client
Proposed fix
table now

Description Nicole C. Engard 2011-04-13 15:41:24 UTC
Created attachment 3909 [details]
fines in staff client

On the staff client when viewing fines there is an extra row that is causing things to not line up properly.
Comment 1 Owen Leonard 2011-04-13 15:55:07 UTC
Created attachment 3910 [details] [review]
Proposed fix

Fixing a template variable scope error fixes the column error. This patch also includes a fix for the column span error in the table footer.
Comment 2 Chris Cormack 2011-04-14 03:06:54 UTC
Pushed, please test
Comment 3 Nicole C. Engard 2011-04-20 01:02:30 UTC
Created attachment 3953 [details]
table now

The extra column is gone after the patch - but I'm going to be nit picky and say that there is a white square at the bottom of the print column that should probably be grey like the rest of the row :)
Comment 4 Owen Leonard 2011-04-20 13:19:27 UTC
> but I'm going to be nit picky and
> say that there is a white square at the bottom of the print column that should
> probably be grey like the rest of the row :)

I'll see your nit picky and raise you multiple lines of template logic in my patch which should have eliminated that white square. Seriously though, I can't reproduce this. If you can figure out how to make this happen I'll take another look.
Comment 5 Nicole C. Engard 2011-04-20 14:56:27 UTC
once again it's a FF4 thing ... apparently FF4 has all kinds of issues :(
Comment 6 Magnus Enger 2011-05-16 09:35:19 UTC
The table is properly aligned in current master.