Summary: | Extra column on fines in staff client | ||
---|---|---|---|
Product: | Koha | Reporter: | Nicole C. Engard <nengard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
Severity: | normal | ||
Priority: | PATCH-Sent (DO NOT USE) | CC: | chris, magnus |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 5917 | ||
Attachments: |
fines in staff client
Proposed fix table now |
Created attachment 3910 [details] [review] Proposed fix Fixing a template variable scope error fixes the column error. This patch also includes a fix for the column span error in the table footer. Pushed, please test Created attachment 3953 [details]
table now
The extra column is gone after the patch - but I'm going to be nit picky and say that there is a white square at the bottom of the print column that should probably be grey like the rest of the row :)
> but I'm going to be nit picky and
> say that there is a white square at the bottom of the print column that should
> probably be grey like the rest of the row :)
I'll see your nit picky and raise you multiple lines of template logic in my patch which should have eliminated that white square. Seriously though, I can't reproduce this. If you can figure out how to make this happen I'll take another look.
once again it's a FF4 thing ... apparently FF4 has all kinds of issues :( The table is properly aligned in current master. |
Created attachment 3909 [details] fines in staff client On the staff client when viewing fines there is an extra row that is causing things to not line up properly.